Review Request 110163: Use KexiDB's TableViewData in the biblio table model

[Smit Patel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110163/#review31518
-----------------------------------------------------------

Ship it!


Ship It!

- Smit Patel


On April 24, 2013, 9:18 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110163/
> -----------------------------------------------------------
> 
> (Updated April 24, 2013, 9:18 p.m.)
> 
> 
> Review request for Calligra, Oleg Kukharchuk, Adam Pigg, Smit Patel, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik.
> 
> 
> Description
> -------
> 
> Use KexiDB's TableViewData in the biblio table model. As a result the model is properly editable. 
> 
> Moreover, unlike the original solution, thanks to buffering in TableViewData all operations are no longer expensive:
> - row count is O(1),
> - data altering is O(1),
> - data retrieving (individual cells) is O(1)
> 
> Filtering works too. The code is also relatively simple.
> 
> This patch depends on https://git.reviewboard.kde.org/r/110162 (KexiTableViewColumn and KexiTableViewData from calligradb).
> 
> 
> Diffs
> -----
> 
>   libs/kotext/BibliographyTableModel.h PRE-CREATION 
>   libs/kotext/BibliographyTableModel.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110163/diff/
> 
> 
> Testing
> -------
> 
> Features of the Bibliography Database window work properly.
> 
> Not sure about memory leaks, e.g. two cases of Cursor lifetime: m_conn->deleteCursor()
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130424/8293a1f8/attachment.htm>