Review Request 109877: Make calligra compile with clang
Yue Liu
yue.liu at mail.com
Sat Apr 6 04:26:13 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109877/#review30535
-----------------------------------------------------------
Ship it!
Ship It!
- Yue Liu
On April 5, 2013, 5:41 p.m., Fabian Kosmale wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109877/
> -----------------------------------------------------------
>
> (Updated April 5, 2013, 5:41 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> Clang doesn't support variable length arrays for non POD types (see http://clang.llvm.org/compatibility.html#vla). I chose std::vector instead of QVector, because the later has AFAIK a greater impact on used memory and we don't need its additional features.
>
>
> Diffs
> -----
>
> plugins/staging/pivottables/pivotmain.cpp 6045618bfcb64941ca9a82b8be072e9786c222dc
>
> Diff: http://git.reviewboard.kde.org/r/109877/diff/
>
>
> Testing
> -------
>
> It now compiles and the applications still run. However I don't know how to test the functionality (Pivo) of the file I've changed.
>
>
> Thanks,
>
> Fabian Kosmale
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130406/00a5eb5c/attachment.htm>
More information about the calligra-devel
mailing list