Review Request 109877: Make calligra compile with clang

[Fabian Kosmale]

> On April 5, 2013, 7:04 p.m., Boudewijn Rempt wrote:
> > Hm... This is kinda weird as a patch. I mean, the original used QVector, and to replace that with std::vector seems weird as a compile fix. I don't really know the ins and outs, but I'm not gonna press ship-it just yet.

I hope I'm not completely mistaken, but I think it actually didn't used a QVector, but a QVector array, consisting of n elements, where n is the value returned by the function. So I changed it from QVector array to std::vector<QVector>. However if anyone has a better idea, I'm more than happy to hear it.


- Fabian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109877/#review30507
-----------------------------------------------------------


On April 5, 2013, 5:41 p.m., Fabian Kosmale wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109877/
> -----------------------------------------------------------
> 
> (Updated April 5, 2013, 5:41 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Clang doesn't support variable length arrays for non POD types (see http://clang.llvm.org/compatibility.html#vla). I chose std::vector instead of QVector, because the later has AFAIK a greater impact on used memory and we don't need its additional features.
> 
> 
> Diffs
> -----
> 
>   plugins/staging/pivottables/pivotmain.cpp 6045618bfcb64941ca9a82b8be072e9786c222dc 
> 
> Diff: http://git.reviewboard.kde.org/r/109877/diff/
> 
> 
> Testing
> -------
> 
> It now compiles and the applications still run. However I don't know how to test the functionality (Pivo) of the file I've changed.
> 
> 
> Thanks,
> 
> Fabian Kosmale
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130405/dc590174/attachment.htm>