Review Request: Better support for hatch background
Inge Wallin
inge at lysator.liu.se
Sat Sep 1 13:44:22 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106115/#review18385
-----------------------------------------------------------
Ship it!
Since we seem to agree and yet nobody has done anything concrete, let me just press the ship-it button.
- Inge Wallin
On Aug. 25, 2012, 5:38 a.m., Thorsten Zachmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106115/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2012, 5:38 a.m.)
>
>
> Review request for Calligra and Jan Hambrecht.
>
>
> Description
> -------
>
> Implement correct support for hatch background as defined in odf. With this patch the different styles, freely defined angles and distance between the lines of the hatch is supported.
>
> This patch also changes the KoColorBackground to also use the d pointer of the parent which reduces the memory needed for a KoColorBackground.
>
>
> This addresses bugs 260534 and 298708.
> http://bugs.kde.org/show_bug.cgi?id=260534
> http://bugs.kde.org/show_bug.cgi?id=298708
>
>
> Diffs
> -----
>
> libs/flake/CMakeLists.txt 15b6e6c
> libs/flake/KoColorBackground.h 88b61bd
> libs/flake/KoColorBackground.cpp 66d7ffc
> libs/flake/KoColorBackground_p.h PRE-CREATION
> libs/flake/KoHatchBackground.h PRE-CREATION
> libs/flake/KoHatchBackground.cpp PRE-CREATION
> libs/flake/KoShape.cpp 3a32e9f
>
> Diff: http://git.reviewboard.kde.org/r/106115/diff/
>
>
> Testing
> -------
>
> Tested with cstester and the documents of the bug reports.
>
>
> Thanks,
>
> Thorsten Zachmann
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120901/ddecf16a/attachment.htm>
More information about the calligra-devel
mailing list