<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106115/">http://git.reviewboard.kde.org/r/106115/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since we seem to agree and yet nobody has done anything concrete, let me just press the ship-it button.</pre>
<br />
<p>- Inge</p>
<br />
<p>On August 25th, 2012, 5:38 a.m., Thorsten Zachmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Jan Hambrecht.</div>
<div>By Thorsten Zachmann.</div>
<p style="color: grey;"><i>Updated Aug. 25, 2012, 5:38 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implement correct support for hatch background as defined in odf. With this patch the different styles, freely defined angles and distance between the lines of the hatch is supported.
This patch also changes the KoColorBackground to also use the d pointer of the parent which reduces the memory needed for a KoColorBackground.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with cstester and the documents of the bug reports.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=260534">260534</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=298708">298708</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/CMakeLists.txt <span style="color: grey">(15b6e6c)</span></li>
<li>libs/flake/KoColorBackground.h <span style="color: grey">(88b61bd)</span></li>
<li>libs/flake/KoColorBackground.cpp <span style="color: grey">(66d7ffc)</span></li>
<li>libs/flake/KoColorBackground_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoHatchBackground.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoHatchBackground.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoShape.cpp <span style="color: grey">(3a32e9f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106115/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>