Review Request: Show message when no database server drivers are found, when trying to create/open/import project.

Dimitrios Tanis jtanis at tanisfood.gr
Tue Oct 30 23:18:36 GMT 2012



> On Oct. 30, 2012, 8:40 p.m., Jarosław Staniek wrote:
> > kexi/main/startup/KexiOpenProjectAssistant.cpp, line 110
> > <http://git.reviewboard.kde.org/r/107100/diff/2/?file=92718#file92718line110>
> >
> >     ->
> >     }
> >     else {
> >     
> >     (+fix in 3 other places)

hmm, Didn't find that in KDE coding style. Nice to know.


- Dimitrios


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107100/#review21162
-----------------------------------------------------------


On Oct. 29, 2012, 12:28 a.m., Dimitrios Tanis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107100/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2012, 12:28 a.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek, Adam Pigg, and Oleg Kukharchuk.
> 
> 
> Description
> -------
> 
> When trying to create/open/import a project that requires a database server driver, if none is found display a message informing about it and giving general instructions what to do.
> 
> 
> This addresses bug 131092.
>     http://bugs.kde.org/show_bug.cgi?id=131092
> 
> 
> Diffs
> -----
> 
>   kexi/main/startup/KexiNewProjectAssistant.h af89ef24ad974ccb61554182ae595898eb1dd96e 
>   kexi/main/startup/KexiNewProjectAssistant.cpp 75efbc1c7c15884ded9f30dc79e1913cf3d3984f 
>   kexi/main/startup/KexiOpenProjectAssistant.h 595b0bb1b548f75542ceda04a8129f78330d7c95 
>   kexi/main/startup/KexiOpenProjectAssistant.cpp 6af1e01373509db5a452381b6b24fca73ae21aaa 
>   kexi/widget/KexiConnectionSelectorWidget.h 43bd7ccc041bd81f9c3884b993ccd12656480071 
>   kexi/widget/KexiConnectionSelectorWidget.cpp fd5c414a1c3b4dd9e0ab123780f9735785f1dd94 
> 
> Diff: http://git.reviewboard.kde.org/r/107100/diff/
> 
> 
> Testing
> -------
> 
> Works when no db server driver present. IMHO though this solution is not elegant at all as it is implemented in 3 different places.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/107100/s/800/
> 
>   http://git.reviewboard.kde.org/r/107100/s/801/
> 
>   http://git.reviewboard.kde.org/r/107100/s/802/
> 
> 
> Thanks,
> 
> Dimitrios Tanis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121030/6aaca572/attachment.htm>


More information about the calligra-devel mailing list