Review Request: Show message when no database server drivers are found, when trying to create/open/import project.

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107100/#review21162
-----------------------------------------------------------


Good job, please see the comments.


kexi/main/startup/KexiNewProjectAssistant.cpp
<http://git.reviewboard.kde.org/r/107100/#comment16563>

    100% future-proof would be to iterate over const KexiDB::Driver::InfoHash DriverManager::driversInfo() and find at least one server-based driver (which has !Driver::Info::fileBased).
    
    The code can be put into a function bool KexiUtils::hasDatabaseServerDrivers() in kexiutils/utils.h/cpp and reused in 3 places.
    



kexi/main/startup/KexiNewProjectAssistant.cpp
<http://git.reviewboard.kde.org/r/107100/#comment16565>

    Move lines 328..341 to widget/KexiServerDriverNotFoundMessage.h/cpp as KexiServerDriverNotFoundMessage class and use it in 3 places.



kexi/main/startup/KexiNewProjectAssistant.cpp
<http://git.reviewboard.kde.org/r/107100/#comment16566>

    Based on http://techbase.kde.org/Development/Tutorials/Localization/i18n_Semantics, this KUIT is better (not tested but close to proper):
     
    i18nc("@info",
    "<title>No database server drivers found</title>"
    "<para>In order to connect to a database server please ensure you have a database driver installed which matches your server.</para>"
    "<title>Details</title>"
    "<para>To obtain database drivers please use your Package Manager to search and install packages named <filename>calligra-kexi-xxxx-driver</filename>. Please note that your package names could vary slightly according to the distribution you use.</para>");
    
    Please note, it's been also proofread by native speaker (piggz).



kexi/main/startup/KexiOpenProjectAssistant.h
<http://git.reviewboard.kde.org/r/107100/#comment16567>

    fix indent



kexi/main/startup/KexiOpenProjectAssistant.h
<http://git.reviewboard.kde.org/r/107100/#comment16568>

    fix indent
    



kexi/main/startup/KexiOpenProjectAssistant.cpp
<http://git.reviewboard.kde.org/r/107100/#comment16569>

    fix indent



kexi/main/startup/KexiOpenProjectAssistant.cpp
<http://git.reviewboard.kde.org/r/107100/#comment16570>

    ->
    }
    else {
    
    (+fix in 3 other places)


- Jarosław Staniek


On Oct. 29, 2012, 12:28 a.m., Dimitrios Tanis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107100/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2012, 12:28 a.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek, Adam Pigg, and Oleg Kukharchuk.
> 
> 
> Description
> -------
> 
> When trying to create/open/import a project that requires a database server driver, if none is found display a message informing about it and giving general instructions what to do.
> 
> 
> This addresses bug 131092.
>     http://bugs.kde.org/show_bug.cgi?id=131092
> 
> 
> Diffs
> -----
> 
>   kexi/main/startup/KexiNewProjectAssistant.h af89ef24ad974ccb61554182ae595898eb1dd96e 
>   kexi/main/startup/KexiNewProjectAssistant.cpp 75efbc1c7c15884ded9f30dc79e1913cf3d3984f 
>   kexi/main/startup/KexiOpenProjectAssistant.h 595b0bb1b548f75542ceda04a8129f78330d7c95 
>   kexi/main/startup/KexiOpenProjectAssistant.cpp 6af1e01373509db5a452381b6b24fca73ae21aaa 
>   kexi/widget/KexiConnectionSelectorWidget.h 43bd7ccc041bd81f9c3884b993ccd12656480071 
>   kexi/widget/KexiConnectionSelectorWidget.cpp fd5c414a1c3b4dd9e0ab123780f9735785f1dd94 
> 
> Diff: http://git.reviewboard.kde.org/r/107100/diff/
> 
> 
> Testing
> -------
> 
> Works when no db server driver present. IMHO though this solution is not elegant at all as it is implemented in 3 different places.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/107100/s/800/
> 
>   http://git.reviewboard.kde.org/r/107100/s/801/
> 
>   http://git.reviewboard.kde.org/r/107100/s/802/
> 
> 
> Thanks,
> 
> Dimitrios Tanis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121030/632b3abe/attachment.htm>