Review Request: Kexi Tables/Forms: show indication that edited or pasted text is trimmed

[Jarosław Staniek]

> On Oct. 29, 2012, 12:56 a.m., Dimitrios Tanis wrote:
> > kexi/plugins/forms/widgets/kexidblineedit.cpp, line 169
> > <http://git.reviewboard.kde.org/r/107068/diff/1/?file=92482#file92482line169>
> >
> >     Since we no longer rely on maxLength directly to restrict overflowed text, wouldn't it be better to have text overflow UNTIL we choose to save the record? That could allow for pasting field data longer than maxLength set and give the user a chance to do the trim. If he just saves the record, let Kexi handle it. That could save the user some akward trimmings eg. cutting in the middle of a word or sentence. In that context the warning would read "Text WILL be truncated to xxx characters UPON SAVING THE RECORD because of limit for "yyy" field"
> 
> Jarosław Staniek wrote:
>     Dimitrios, that's good idea, thanks. 
>     
>     How about: 
>     - displaying the warning as before with text you proposed
>     - while user is editing, hide the warning if overflow is fixed (optionally, display info message "Fixed, no trimming needed" in place of the warning, for a while)
>     - upon saving, trim if needed
>
> 
> Dimitrios Tanis wrote:
>     Seems OK.
>     Only one note: I was thinking not to have any message when overflow is fixed. Just display the message as long as we have overflowed text. If the user fixes it just close it. Much like e.g. the date error message, we don't inform the user that he entered a correct date after he changes it.

OK


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107068/#review21077
-----------------------------------------------------------


On Oct. 27, 2012, 7:41 a.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107068/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2012, 7:41 a.m.)
> 
> 
> Review request for Calligra, Adam Pigg, Dimitrios Tanis, Radosław Wicik, and Oleg Kukharchuk.
> 
> 
> Description
> -------
> 
> Tables/Forms: show indication that edited or pasted text is trimmed.
> 
> See also http://forum.kde.org/viewtopic.php?f=221&t=102475 thread.
> 
> Screencasts with the feature:
> http://www.youtube.com/watch?v=Qdd7CaBonq0
> http://www.youtube.com/watch?v=wjyGsWxnAEs
> 
> 
> This addresses bug 301136.
>     http://bugs.kde.org/show_bug.cgi?id=301136
> 
> 
> Diffs
> -----
> 
>   kexi/core/kexidataiteminterface.h 639e8758c82121b9a6998ba6c719bd1d97a3f910 
>   kexi/core/kexidataiteminterface.cpp 8eb9d4dfe60b666f0528ffc45b6471520533b765 
>   kexi/plugins/forms/kexiformscrollview.h 43ce3f9aabab8197086c3c3c7658fc51362d9c7f 
>   kexi/plugins/forms/kexiformscrollview.cpp 9ba0fc442fa28534768b36c81c4551e5b8e3cb3f 
>   kexi/plugins/forms/widgets/kexidblineedit.h fbf686a2c72bf2d7fdf703b9e03d3eaa96ab3147 
>   kexi/plugins/forms/widgets/kexidblineedit.cpp e1e3f771e3256178c174591f3af6453729c69325 
>   kexi/widget/dataviewcommon/kexidataawareobjectiface.h ef5a892fb371263787fd03ca5884ec3f165cbd2d 
>   kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp ba5266c50024349a4606312e916f9b94a59b2e59 
>   kexi/widget/tableview/kexiinputtableedit.h fe20fb1a46298371905f1eb9672484417f28fc81 
>   kexi/widget/tableview/kexiinputtableedit.cpp 8c62a289d1752ce2464179de1f5155869dea01bd 
>   kexi/widget/tableview/kexitableview.h e01ba05c4340e5d7f8fbb409c01c6cdd0c9b7630 
>   kexi/widget/tableview/kexitableview.cpp a0e17c6c1069d3d7fd1a0c3893a2fd5f6591330e 
>   kexi/widget/tableview/kexitextformatter.h 880a36c9e3702ccdb48ffbf5fb92759b4d0be5b7 
>   kexi/widget/tableview/kexitextformatter.cpp c119056e63815c0eb4220efb389c5cd1352a79cc 
> 
> Diff: http://git.reviewboard.kde.org/r/107068/diff/
> 
> 
> Testing
> -------
> 
> Properly displays warnings and trims data
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121030/f906406d/attachment.htm>