Review Request: [crash workaround] disable Voice combobox in SimpleEntryTool for Music shape

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105674/#review20987
-----------------------------------------------------------

Ship it!


Properly speaking, it's for Mek to decide on this. However, it's a crasher and I doubt that there'll be a lot of development on the music shape any time soon, so please do ship it.

- Boudewijn Rempt


On July 23, 2012, 2 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105674/
> -----------------------------------------------------------
> 
> (Updated July 23, 2012, 2 p.m.)
> 
> 
> Review request for Calligra and Marijn Kruisselbrink.
> 
> 
> Description
> -------
> 
> The SimpleEntryTool just has 4 voices preset, without synchronizing to the actual part, which results in a crash if another voice is selected there.
> 
> This patch simply disables the Voice combobox as a workaround for now, until the support for voices is complete.
> 
> Okay to backport to 2.5?
> 
> 
> Diffs
> -----
> 
>   plugins/musicshape/dialogs/SimpleEntryWidget.ui 1f26c9d 
> 
> Diff: http://git.reviewboard.kde.org/r/105674/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121027/1b9e2cf7/attachment.htm>