Review Request: Move the theme manager from Krita to KoMainWindow

[Boudewijn Rempt]

> On Oct. 24, 2012, 11:54 a.m., C. Boemann wrote:
> > I personally don't see te need to have a single app themed, but Iøm not objecting to this either
> > 
> > I'll let someone else approve though

Users want it... They want to have a light-themed browser or chat window, and a dark krita or karbon. And I cannot hack this in into the right place without touching the calligra libs.


- Boudewijn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107002/#review20784
-----------------------------------------------------------


On Oct. 23, 2012, 7:28 a.m., Boudewijn Rempt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107002/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2012, 7:28 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This makes per-app theming available to all Calligra applications, make sure the initial dialog is themed as well and finally avoid a nasty problem with some styles where the menubar and toolbar aren't themed if they aren't created after the theme is applied
> 
> The theme manager itself comes from Digikam and I intentionally didn't change any code there (except to disable starting the color kcm on windows) so it remains easy to use new versions. When frameworks 5 ends the feature freeze for the kde libraries, we should propose this as a shared component.
> 
> 
> Diffs
> -----
> 
>   krita/ui/CMakeLists.txt a72e620 
>   krita/ui/kis_view2.cpp 738ed88 
>   krita/ui/thememanager.h 3d4680c 
>   krita/ui/thememanager.cpp 2765f7b 
>   krita/ui/thememanager.rc 9a66017 
>   libs/main/CMakeLists.txt 2ad52c9 
>   libs/main/KoMainWindow.cpp 67c1aa2 
>   libs/main/calligra_shell.rc b393dd6 
>   libs/main/thememanager.h PRE-CREATION 
>   libs/main/thememanager.cpp PRE-CREATION 
>   libs/main/thememanager.rc PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107002/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Words, themed.
>   http://git.reviewboard.kde.org/r/107002/s/797/
> 
> 
> Thanks,
> 
> Boudewijn Rempt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121024/942e2c4a/attachment.htm>