<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107002/">http://git.reviewboard.kde.org/r/107002/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 24th, 2012, 11:54 a.m., <b>C. Boemann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I personally don't see te need to have a single app themed, but Iøm not objecting to this either
I'll let someone else approve though</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Users want it... They want to have a light-themed browser or chat window, and a dark krita or karbon. And I cannot hack this in into the right place without touching the calligra libs.</pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On October 23rd, 2012, 7:28 a.m., Boudewijn Rempt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Boudewijn Rempt.</div>
<p style="color: grey;"><i>Updated Oct. 23, 2012, 7:28 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This makes per-app theming available to all Calligra applications, make sure the initial dialog is themed as well and finally avoid a nasty problem with some styles where the menubar and toolbar aren't themed if they aren't created after the theme is applied
The theme manager itself comes from Digikam and I intentionally didn't change any code there (except to disable starting the color kcm on windows) so it remains easy to use new versions. When frameworks 5 ends the feature freeze for the kde libraries, we should propose this as a shared component.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/ui/CMakeLists.txt <span style="color: grey">(a72e620)</span></li>
<li>krita/ui/kis_view2.cpp <span style="color: grey">(738ed88)</span></li>
<li>krita/ui/thememanager.h <span style="color: grey">(3d4680c)</span></li>
<li>krita/ui/thememanager.cpp <span style="color: grey">(2765f7b)</span></li>
<li>krita/ui/thememanager.rc <span style="color: grey">(9a66017)</span></li>
<li>libs/main/CMakeLists.txt <span style="color: grey">(2ad52c9)</span></li>
<li>libs/main/KoMainWindow.cpp <span style="color: grey">(67c1aa2)</span></li>
<li>libs/main/calligra_shell.rc <span style="color: grey">(b393dd6)</span></li>
<li>libs/main/thememanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/thememanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/thememanager.rc <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107002/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107002/s/797/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/23/themed_words_400x100.png" style="border: 1px black solid;" alt="Words, themed." /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>