Review Request: Change Stage and Flow to have infinite type canvas

Yue Liu yue.liu at mail.com
Sat Oct 13 15:55:03 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104928/#review20269
-----------------------------------------------------------


The patch caused a problem when you drag a shape to the canvas. When you are dragging and cursor just past the edge of the canvas, canvas will expand, if you drag slowly, canvas will continue expanding and you lost your position in the canvas. I think it would be better letting canvas expand after drag & drop is done. It will make canvas less jumping. It won't hurt the feature of canvas expanding since users don't need to expand too much.

- Yue Liu


On May 17, 2012, 7:14 p.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104928/
> -----------------------------------------------------------
> 
> (Updated May 17, 2012, 7:14 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> KoPageApp applications Stage and Flow used to have extra space reserved around the page/slide so objects could be put there. However that made it really hard for the user to work with.
> 
> This patch changes that so there si no space around the page/slide. But.. instead you can drag objects outside the page/slide without any limit at all
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShapeManager.h 520381d 
>   libs/flake/KoShapeManager.cpp 88c522f 
>   libs/kopageapp/KoPACanvas.cpp 4a4748c 
>   libs/kopageapp/KoPAView.h 01fbdf1 
>   libs/kopageapp/KoPAView.cpp 4d13dfa 
>   libs/kopageapp/KoPAViewModeNormal.cpp d5aa5f6 
>   libs/widgets/KoZoomController.h 4f4c6a2 
>   libs/widgets/KoZoomController.cpp e10c5b4 
>   stage/part/KPrViewModeNotes.h b707770 
>   stage/part/KPrViewModeNotes.cpp c951ade 
> 
> Diff: http://git.reviewboard.kde.org/r/104928/diff/
> 
> 
> Testing
> -------
> 
> I've tested zooming in and out in Stage normal, notes, and sorter viewmodes, and in Flow.
> 
> I've tested that running presentations still work, however I've not tested presenterview.
> 
> I've tested moving shapes outside the page/slide in both Stage and Flow.
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121013/4907a59a/attachment.htm>


More information about the calligra-devel mailing list