Review Request: This increases the flexibility of Statistics Docker Plugin , by allowing it to layout its widgets horizontally when user places it in the bottom area

Inge Wallin inge at lysator.liu.se
Sat Oct 13 07:40:06 BST 2012



> On Sept. 5, 2012, 2:56 p.m., Boudewijn Rempt wrote:
> > Wasn't this pushed already?
> 
> Jarosław Staniek wrote:
>     It was but I've seen no reference to my concern (just "fixed" mark), that's why I started another iteration. It's never to late to improve things, and usability is important one.
>     
>     in master words/part/dockers/StatisticsPreferencesPopup.ui still contains <string>Flesch Reading Ease</string>.

Can you close this, Shreya? The patch is committed and every issue is taken care of, and there is even further development done on this afterwards.


- Inge


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106252/#review18551
-----------------------------------------------------------


On Aug. 31, 2012, 12:19 p.m., Shreya Pandit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106252/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2012, 12:19 p.m.)
> 
> 
> Review request for Calligra, Thomas Pfeiffer and Inge Wallin.
> 
> 
> Description
> -------
> 
> This allows the Statistics Docker to update its layout horizontally, when placed in bottom area. 
> 
> 
> Diffs
> -----
> 
>   words/part/dockers/KWStatistics.h c480502 
>   words/part/dockers/KWStatistics.cpp a006d97 
>   words/part/dockers/KWStatisticsDocker.h fab6c7f 
>   words/part/dockers/KWStatisticsDocker.cpp 0bc8130 
>   words/part/dockers/KWStatisticsDocker.ui 63eaee5 
>   words/part/dockers/StatisticsPreferencesPopup.h b481806 
>   words/part/dockers/StatisticsPreferencesPopup.cpp c741622 
> 
> Diff: http://git.reviewboard.kde.org/r/106252/diff/
> 
> 
> Testing
> -------
> 
> Checked for calligra words and calligra author
> 
> 
> Screenshots
> -----------
> 
> The layout
>   http://git.reviewboard.kde.org/r/106252/s/713/
> 
> 
> Thanks,
> 
> Shreya Pandit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121013/712da116/attachment.htm>


More information about the calligra-devel mailing list