Review Request: Add functionality to video shape

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106756/#review20041
-----------------------------------------------------------


First of all thanks for working on the videoshape - it's been my intention for ages to do some of what you have done.

The d-pointer'fication is not nessesary for plugins, but it cannot hurt either :)

My biggest concern is the change/implementation of the mousepress. This breaks moel/view, and I think we should find some other way to do this. Not quite sure how but let's brainstorm with zagge as well.

Other than that I found a few small issues


libs/flake/KoShape.h
<http://git.reviewboard.kde.org/r/106756/#comment15869>

    This breaks the model/view separation
    



plugins/videoshape/VideoCollection.h
<http://git.reviewboard.kde.org/r/106756/#comment15870>

    please update apidoc



plugins/videoshape/VideoData.cpp
<http://git.reviewboard.kde.org/r/106756/#comment15871>

    spaces



plugins/videoshape/VideoData.cpp
<http://git.reviewboard.kde.org/r/106756/#comment15872>

    spaces



plugins/videoshape/VideoData.cpp
<http://git.reviewboard.kde.org/r/106756/#comment15873>

    I know I wrote this, but 8192 seems a better value, if we don't want to up it even further or do something even better


- C. Boemann


On Oct. 7, 2012, 3:56 p.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106756/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2012, 3:56 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Add the following enhancements to videoshape
> 
> 1) Enable videoshape in Words
> 2) Add playback controls to Video playback(Volume Control, Playback seeker)
> 3) Ability to save video within ODF documents.
> 4) Ability to change video of a video shape
> 5) Ability to play video in Words/Author by clicking on the play icon(inside the shape at the center).
> 6) Thumbnails for videoshape
> 
> The thumbnail functionality is implemented but untested and hence #ifd out. The reason for this is that the Phonon::VideoWidget::snapshot() functionality is not implemented in the gstreamer backend(the one that I have). I have posted a related mail [1] to phonon-backends ml regarding this.
> 
> [1] http://mail.kde.org/pipermail/phonon-backends/2012-October/000711.html
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShape.h 77a630c 
>   libs/flake/KoShape.cpp cdb0c6d 
>   libs/flake/KoToolProxy.cpp 375f1e3 
>   plugins/videoshape/CMakeLists.txt f4d81b6 
>   plugins/videoshape/ChangeVideoCommand.h PRE-CREATION 
>   plugins/videoshape/ChangeVideoCommand.cpp PRE-CREATION 
>   plugins/videoshape/FullScreenPlayer.h aee2f90 
>   plugins/videoshape/FullScreenPlayer.cpp a0faa5c 
>   plugins/videoshape/Plugin.cpp 39c38f0 
>   plugins/videoshape/SelectVideoWidget.h PRE-CREATION 
>   plugins/videoshape/SelectVideoWidget.cpp PRE-CREATION 
>   plugins/videoshape/VideoCollection.h f5ece64 
>   plugins/videoshape/VideoCollection.cpp 91c8a2d 
>   plugins/videoshape/VideoData.h 7bd7b7a 
>   plugins/videoshape/VideoData.cpp b5f4699 
>   plugins/videoshape/VideoShape.h e9e65da 
>   plugins/videoshape/VideoShape.cpp 32744ab 
>   plugins/videoshape/VideoShapeConfigWidget.h 251dc75 
>   plugins/videoshape/VideoShapeConfigWidget.cpp 4f5d22e 
>   plugins/videoshape/VideoThumbnail.h PRE-CREATION 
>   plugins/videoshape/VideoThumbnail.cpp PRE-CREATION 
>   plugins/videoshape/VideoTool.h PRE-CREATION 
>   plugins/videoshape/VideoTool.cpp PRE-CREATION 
>   plugins/videoshape/VideoToolFactory.h PRE-CREATION 
>   plugins/videoshape/VideoToolFactory.cpp PRE-CREATION 
>   plugins/videoshape/forms/VideoToolWidget.ui PRE-CREATION 
>   words/part/wordsrc 3b3c543 
> 
> Diff: http://git.reviewboard.kde.org/r/106756/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gopalakrishna Bhat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121007/2d063135/attachment.htm>