Review Request: Move Show Statusbar action from menu Settings to menu View

Friedrich W. H. Kossebau kossebau at kde.org
Wed Oct 3 15:23:43 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106650/#review19830
-----------------------------------------------------------


I think this patch should better not be commited.

It surely all comes down to what is thought of with the term "View". For me it refers to the view of the document/content, not the view of the application/window. Surely this is not defined anywhere and different programs put things differently in "View" and "Settings".

But, in any case, moving "Show Statusbar" like proposed in Calligra apps would mean:
* inconsistency with all other kdelibs-based programs
* inconsistency with other settings for the (window) view, like toolbar and dockers

IMHO this checkbox action should stay in the Settings menu, for consistency.
It has been there since at least KDE3 times, and many people got used to it.

This patch should be rather proposed for kdelibs, if you think this change is worth it (Firefox 15.1 devs at least agree with you, and have sidebar/toolbar settings under View menu).
But please lets stay consistent as possible in the same environment.

- Friedrich W. H. Kossebau


On Sept. 30, 2012, 12:10 a.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106650/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2012, 12:10 a.m.)
> 
> 
> Review request for Calligra, Marijn Kruisselbrink, Thorsten Zachmann, and C. Boemann.
> 
> 
> Description
> -------
> 
> This patch moves the action "Show Statusbar" to the View menu.
> 
> It's obvious that to show the statusbar or not is a View thing.
> 
> One thing to comment on is whether all applications should have this setting.  Currently they don't.
> 
> 
> Diffs
> -----
> 
>   sheets/sheets.rc 7eae858 
>   stage/part/stage.rc 2dba463 
>   stage/stage.rc d0b912f 
>   words/part/author/author.rc 14c5e91 
>   words/part/words.rc 7ccbd34 
> 
> Diff: http://git.reviewboard.kde.org/r/106650/diff/
> 
> 
> Testing
> -------
> 
> Tested all affected applications.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121003/f2ce789e/attachment.htm>


More information about the calligra-devel mailing list