<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106650/">http://git.reviewboard.kde.org/r/106650/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think this patch should better not be commited.
It surely all comes down to what is thought of with the term "View". For me it refers to the view of the document/content, not the view of the application/window. Surely this is not defined anywhere and different programs put things differently in "View" and "Settings".
But, in any case, moving "Show Statusbar" like proposed in Calligra apps would mean:
* inconsistency with all other kdelibs-based programs
* inconsistency with other settings for the (window) view, like toolbar and dockers
IMHO this checkbox action should stay in the Settings menu, for consistency.
It has been there since at least KDE3 times, and many people got used to it.
This patch should be rather proposed for kdelibs, if you think this change is worth it (Firefox 15.1 devs at least agree with you, and have sidebar/toolbar settings under View menu).
But please lets stay consistent as possible in the same environment.</pre>
<br />
<p>- Friedrich W. H.</p>
<br />
<p>On September 30th, 2012, 12:10 a.m., Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Marijn Kruisselbrink, Thorsten Zachmann, and C. Boemann.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated Sept. 30, 2012, 12:10 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch moves the action "Show Statusbar" to the View menu.
It's obvious that to show the statusbar or not is a View thing.
One thing to comment on is whether all applications should have this setting. Currently they don't.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested all affected applications.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>sheets/sheets.rc <span style="color: grey">(7eae858)</span></li>
<li>stage/part/stage.rc <span style="color: grey">(2dba463)</span></li>
<li>stage/stage.rc <span style="color: grey">(d0b912f)</span></li>
<li>words/part/author/author.rc <span style="color: grey">(14c5e91)</span></li>
<li>words/part/words.rc <span style="color: grey">(7ccbd34)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106650/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>