Review Request: Sort styles according to usage in the docker's combos

Pierre Stirnweiss pstirnweiss at googlemail.com
Tue Nov 27 19:30:32 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107445/
-----------------------------------------------------------

(Updated Nov. 27, 2012, 7:30 p.m.)


Review request for Calligra, Inge Wallin and C. Boemann.


Changes
-------

Fix problems highlighted by C. Boemann


Description
-------

This introduces sorting of the styles in the combos according to usage.
This is a first step into revamping the styles handling.


Diffs (updated)
-----

  libs/kotext/KoTextEditor.h 64f47bb 
  libs/kotext/KoTextEditor_format.cpp 8985fcc 
  libs/kotext/styles/KoCharacterStyle.h 765f49e 
  libs/kotext/styles/KoCharacterStyle.cpp fcb20fd 
  libs/kotext/styles/KoParagraphStyle.h 7ee1787 
  libs/kotext/styles/KoParagraphStyle.cpp f8bffb6 
  libs/kotext/styles/KoStyleManager.h ae2e720 
  libs/kotext/styles/KoStyleManager.cpp 2aa74fe 
  plugins/textshape/CMakeLists.txt 6253323 
  plugins/textshape/TextTool.cpp 207dfd9 
  plugins/textshape/dialogs/AbstractStylesModel.h PRE-CREATION 
  plugins/textshape/dialogs/AbstractStylesModel.cpp PRE-CREATION 
  plugins/textshape/dialogs/DockerStylesComboModel.h PRE-CREATION 
  plugins/textshape/dialogs/DockerStylesComboModel.cpp PRE-CREATION 
  plugins/textshape/dialogs/SimpleCharacterWidget.h d14007c 
  plugins/textshape/dialogs/SimpleCharacterWidget.cpp a7feb89 
  plugins/textshape/dialogs/SimpleParagraphWidget.h a7d7f52 
  plugins/textshape/dialogs/SimpleParagraphWidget.cpp 6fd2f67 
  plugins/textshape/dialogs/StylesCombo.h 484b8fc 
  plugins/textshape/dialogs/StylesCombo.cpp a5e7172 
  plugins/textshape/dialogs/StylesFilteredModelBase.h PRE-CREATION 
  plugins/textshape/dialogs/StylesFilteredModelBase.cpp PRE-CREATION 
  plugins/textshape/dialogs/StylesModel.h 7096d53 
  plugins/textshape/dialogs/StylesModel.cpp 64767f8 
  plugins/textshape/dialogs/ValidParentStylesProxyModel.h PRE-CREATION 
  plugins/textshape/dialogs/ValidParentStylesProxyModel.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/107445/diff/


Testing
-------

Playing around with it did not show regressions with current state of the affair. There are a couple of glitches in handling styles, but these are also present in the current build.


Thanks,

Pierre Stirnweiss

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121127/8ef676a5/attachment.htm>


More information about the calligra-devel mailing list