<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107445/">http://git.reviewboard.kde.org/r/107445/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Inge Wallin and C. Boemann.</div>
<div>By Pierre Stirnweiss.</div>
<p style="color: grey;"><i>Updated Nov. 27, 2012, 7:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix problems highlighted by C. Boemann</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This introduces sorting of the styles in the combos according to usage.
This is a first step into revamping the styles handling.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Playing around with it did not show regressions with current state of the affair. There are a couple of glitches in handling styles, but these are also present in the current build.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/KoTextEditor.h <span style="color: grey">(64f47bb)</span></li>
<li>libs/kotext/KoTextEditor_format.cpp <span style="color: grey">(8985fcc)</span></li>
<li>libs/kotext/styles/KoCharacterStyle.h <span style="color: grey">(765f49e)</span></li>
<li>libs/kotext/styles/KoCharacterStyle.cpp <span style="color: grey">(fcb20fd)</span></li>
<li>libs/kotext/styles/KoParagraphStyle.h <span style="color: grey">(7ee1787)</span></li>
<li>libs/kotext/styles/KoParagraphStyle.cpp <span style="color: grey">(f8bffb6)</span></li>
<li>libs/kotext/styles/KoStyleManager.h <span style="color: grey">(ae2e720)</span></li>
<li>libs/kotext/styles/KoStyleManager.cpp <span style="color: grey">(2aa74fe)</span></li>
<li>plugins/textshape/CMakeLists.txt <span style="color: grey">(6253323)</span></li>
<li>plugins/textshape/TextTool.cpp <span style="color: grey">(207dfd9)</span></li>
<li>plugins/textshape/dialogs/AbstractStylesModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/AbstractStylesModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/DockerStylesComboModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/DockerStylesComboModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SimpleCharacterWidget.h <span style="color: grey">(d14007c)</span></li>
<li>plugins/textshape/dialogs/SimpleCharacterWidget.cpp <span style="color: grey">(a7feb89)</span></li>
<li>plugins/textshape/dialogs/SimpleParagraphWidget.h <span style="color: grey">(a7d7f52)</span></li>
<li>plugins/textshape/dialogs/SimpleParagraphWidget.cpp <span style="color: grey">(6fd2f67)</span></li>
<li>plugins/textshape/dialogs/StylesCombo.h <span style="color: grey">(484b8fc)</span></li>
<li>plugins/textshape/dialogs/StylesCombo.cpp <span style="color: grey">(a5e7172)</span></li>
<li>plugins/textshape/dialogs/StylesFilteredModelBase.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/StylesFilteredModelBase.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/StylesModel.h <span style="color: grey">(7096d53)</span></li>
<li>plugins/textshape/dialogs/StylesModel.cpp <span style="color: grey">(64767f8)</span></li>
<li>plugins/textshape/dialogs/ValidParentStylesProxyModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/ValidParentStylesProxyModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107445/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>