Review Request: fixed SqlitePrepared statement

Oleg Kukharchuk oleg.kuh at gmail.com
Mon Nov 26 13:45:33 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107475/
-----------------------------------------------------------

Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios Tanis.


Description
-------

sqlite3_reset should be called immediately after sqlite3_step, because it always return error when sqlite3_step return SQLITE_ERROR

in existing implementation execute() will cause an error  if previous execute() failed.

Details: http://www.sqlite.org/c3ref/reset.html

Should be fixed in Predicate as well


Diffs
-----

  libs/db/drivers/sqlite/sqlitepreparedstatement.h be81bdc984be14eb67ff6d28d50936baeaa07173 
  libs/db/drivers/sqlite/sqlitepreparedstatement.cpp ffb751ebb1c87c32db95f48797e4c358c7b17991 

Diff: http://git.reviewboard.kde.org/r/107475/diff/


Testing
-------

tested on csv-import


Thanks,

Oleg Kukharchuk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121126/42c45a81/attachment.htm>


More information about the calligra-devel mailing list