Review Request: import csv-file into existing table
Jarosław Staniek
staniek at kde.org
Sun Nov 25 15:07:08 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107330/#review22510
-----------------------------------------------------------
kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<http://git.reviewboard.kde.org/r/107330/#comment17231>
My mistake. Instead I propose using enableButton(ButtonCode id, bool state) - better not to show/hide buttons but enable/disable them, like in migration/importwizard.cpp.
- Jarosław Staniek
On Nov. 23, 2012, 2:06 p.m., Oleg Kukharchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107330/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2012, 2:06 p.m.)
>
>
> Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios Tanis.
>
>
> Description
> -------
>
> * moved to a KAssistantDialog
> * added ability to import into an existent table
>
>
> Diffs
> -----
>
> kexi/plugins/importexport/csv/kexicsvimportdialog.h 15be3504dfc54877bc45d81eb7e59a72f70c9c5a
> kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 5176299599ab034bf256f07ee2651d8a4babb3a0
> kexi/widget/fields/KexiFieldListModel.cpp 91ed791065a34d8a137dc84997506bdd0643b231
> libs/db/drivers/sqlite/sqlitepreparedstatement.cpp ffb751ebb1c87c32db95f48797e4c358c7b17991
>
> Diff: http://git.reviewboard.kde.org/r/107330/diff/
>
>
> Testing
> -------
>
> tested on local branch
> and additional testing needed
>
> (code was not cleaned up yet)
>
>
> Thanks,
>
> Oleg Kukharchuk
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121125/1d614d9f/attachment.htm>
More information about the calligra-devel
mailing list