Review Request: import csv-file into existing table

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107330/#review22496
-----------------------------------------------------------



kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<http://git.reviewboard.kde.org/r/107330/#comment17218>

    -> m_saveMethodWidget = new QWidget(this);



kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<http://git.reviewboard.kde.org/r/107330/#comment17219>

    like above



kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<http://git.reviewboard.kde.org/r/107330/#comment17220>

    like above



kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<http://git.reviewboard.kde.org/r/107330/#comment17221>

    like above



kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<http://git.reviewboard.kde.org/r/107330/#comment17222>

    'to saving' or 'of saving' ?



kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<http://git.reviewboard.kde.org/r/107330/#comment17223>

    -> An error



kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<http://git.reviewboard.kde.org/r/107330/#comment17224>

    Import has been cancelled.



kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<http://git.reviewboard.kde.org/r/107330/#comment17225>

    use ~res



kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<http://git.reviewboard.kde.org/r/107330/#comment17226>

    Error occurred during import.



kexi/widget/fields/KexiFieldListModel.cpp
<http://git.reviewboard.kde.org/r/107330/#comment17227>

    Changes to KexiFieldListModel should be committed separately with detailed explanation.



libs/db/drivers/sqlite/sqlitepreparedstatement.cpp
<http://git.reviewboard.kde.org/r/107330/#comment17228>

    Changes to sqlitepreparedstatement should be committed separately with detailed explanation.


- Jarosław Staniek


On Nov. 23, 2012, 2:06 p.m., Oleg Kukharchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107330/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2012, 2:06 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios Tanis.
> 
> 
> Description
> -------
> 
> * moved to a KAssistantDialog
> * added ability to import into an existent table
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.h 15be3504dfc54877bc45d81eb7e59a72f70c9c5a 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 5176299599ab034bf256f07ee2651d8a4babb3a0 
>   kexi/widget/fields/KexiFieldListModel.cpp 91ed791065a34d8a137dc84997506bdd0643b231 
>   libs/db/drivers/sqlite/sqlitepreparedstatement.cpp ffb751ebb1c87c32db95f48797e4c358c7b17991 
> 
> Diff: http://git.reviewboard.kde.org/r/107330/diff/
> 
> 
> Testing
> -------
> 
> tested on local branch
> and additional testing needed
> 
> (code was not cleaned up yet)
> 
> 
> Thanks,
> 
> Oleg Kukharchuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121124/c3c4d16d/attachment.htm>