Review Request: Move /kdgantt/ to /3rdparty/kdgantt/ and make a real dynamic library out of it.

[Boudewijn Rempt]

On Thursday 22 November 2012 Nov, Inge Wallin wrote:
> On Thursday, November 22, 2012 21:19:05 Boudewijn Rempt wrote:
> > On Thursday 22 November 2012 Nov, Inge Wallin wrote:
> > > On Thursday, November 22, 2012 19:20:08 Inge Wallin wrote:
> > > > > On Nov. 22, 2012, 9:23 a.m., Dag Andersen wrote:
> > > > > > Ship It!
> > > > > 
> > > > > Dag Andersen wrote:
> > > > >     One thing:
> > > > >     The reason it was statically linked, is that there are other
> > > > >     variants of kdgantt out there (like in korganizer). So to avoid
> > > > >     any potential clash I think the lib should be renamed e.g.
> > > > >     calligrakdgantt.
> > > > 
> > > > Fixed.
> > > > 
> > > > 
> > > > - Inge
> > > 
> > > Btw, is this ok to commit to 2.6?
> > 
> > I'd hesitate to do that...
> 
> Then it means that Plan will not work on Windows for all of the 2.6 series.  A 
> pretty big drawback. I started this work now so we could have a full 2.6 
> suite...

Well, there'll be a 2.7 soon enough. It's a big change and we're already really late in the game for 2.6. I won't block it, I just wouldn't do it myself.

-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121123/3d28bfb4/attachment.htm>