Review Request: Move /kdgantt/ to /3rdparty/kdgantt/ and make a real dynamic library out of it.

Jaroslaw Staniek staniek at kde.org
Thu Nov 22 21:01:24 GMT 2012


On 22 November 2012 21:46, Inge Wallin <inge at lysator.liu.se> wrote:
> On Thursday, November 22, 2012 21:19:05 Boudewijn Rempt wrote:
>> On Thursday 22 November 2012 Nov, Inge Wallin wrote:
>> > On Thursday, November 22, 2012 19:20:08 Inge Wallin wrote:
>> > > > On Nov. 22, 2012, 9:23 a.m., Dag Andersen wrote:
>> > > > > Ship It!
>> > > >
>> > > > Dag Andersen wrote:
>> > > >     One thing:
>> > > >     The reason it was statically linked, is that there are other
>> > > >     variants of kdgantt out there (like in korganizer). So to avoid
>> > > >     any potential clash I think the lib should be renamed e.g.
>> > > >     calligrakdgantt.
>> > >
>> > > Fixed.
>> > >
>> > >
>> > > - Inge
>> >
>> > Btw, is this ok to commit to 2.6?
>>
>> I'd hesitate to do that...
>
> Then it means that Plan will not work on Windows for all of the 2.6 series.  A
> pretty big drawback. I started this work now so we could have a full 2.6
> suite...

So I hope this can be considered as a serious bug to fix, not a
cosmetic change. I'd say ok.

-- 
regards / pozdrawiam, Jaroslaw Staniek
 Kexi & Calligra & KDE | http://calligra.org/kexi | http://kde.org
 Qt Certified Specialist | http://qt-project.org
 http://www.linkedin.com/in/jstaniek



More information about the calligra-devel mailing list