better error messages on the build server

Friedrich W. H. Kossebau kossebau at kde.org
Tue May 15 15:44:29 BST 2012


Hi Jos,

good stuff, we need more people working on this like you, thanks!
/me looks at wall without mirror ;)

Am Dienstag, 15. Mai 2012, 13:00:58 schrieb Jos van den Oever:
> Hello all,
> 
> Over the weekend I ported the script to test document round-tripping and
> conversion from python to java. The advantage is an increase in speed and
> better error messages. The runtime for the tests has decreased from two
> hours to one hours and fifteen minutes.
> 
> The main advantage is that the ODF documents are now validated with Jing
> instead of libxml2. libxml2 has an incomplete implementation of Relax NG and
> this led to false positives (reported errors that are not real errors) and
> missed problems.
> 
> Currently 528 failing documents and 2175 passing. So one in five documents
> either crashes calligra or results in invalid ODF.

A few of these invalid ODFs are about 
--- 8< ---
token "0pt" invalid; must be a string matching the regular expression 
"([0-9]*[1-9][0-9]*(\.[0-9]*)?|0+\.[0-9]*[1-9][0-9]*|\.[0-9]*[1-9][0-9]*)
((cm)|(mm)|(in)|(pt)|(pc)|(px))"
--- 8< ---

>From 18.3.18 length or 18.3.26 positiveLength I cannot directly see why "0pt" 
is not valid. Do I miss to read the spec correctly, is that knowledge not 
hardcoded in the spec, or is the regular expression used in the validator 
perhaps too strict?

Cheers
Friedrich



More information about the calligra-devel mailing list