Review Request: Do not show the UI when creating a PDF from a document.

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104913/#review13789
-----------------------------------------------------------

Ship it!


Looks good.  The only thing I don't understand is the changes to the logic behind showShell.


libs/main/KoApplication.cpp
<http://git.reviewboard.kde.org/r/104913/#comment10941>

    This logic is a bit hard to penetrate.  I think a comment explaining it would be good.


- Inge Wallin


On May 13, 2012, 10:04 a.m., Jos van den Oever wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104913/
> -----------------------------------------------------------
> 
> (Updated May 13, 2012, 10:04 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> There is/should be no need to show the user interface when creating a pdf on the commandline.
> 
> 
> Diffs
> -----
> 
>   libs/main/KoApplication.cpp be7254e 
>   libs/main/KoMainWindow.cpp 3338397 
>   libs/main/KoPrintingDialog.cpp 3ed83bd 
> 
> Diff: http://git.reviewboard.kde.org/r/104913/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jos van den Oever
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120513/5d656905/attachment.htm>