Review Request: Do not show the UI when creating a PDF from a document.

Jos van den Oever jos at vandenoever.info
Sun May 13 11:16:35 BST 2012



> On May 13, 2012, 10:08 a.m., Boudewijn Rempt wrote:
> > Aren't you doing the same thing as in https://git.reviewboard.kde.org/r/103476/ here?

The patch touches the same code but is not as pervasive. Also this patch does not just concern the printing dialog but also the showing of the main ui. Neither should be shown when running calligrawords, calligrastage or calligrasheets from the commandline with --export-pdf --export-filename out.pdf.


- Jos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104913/#review13769
-----------------------------------------------------------


On May 13, 2012, 10:04 a.m., Jos van den Oever wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104913/
> -----------------------------------------------------------
> 
> (Updated May 13, 2012, 10:04 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> There is/should be no need to show the user interface when creating a pdf on the commandline.
> 
> 
> Diffs
> -----
> 
>   libs/main/KoApplication.cpp be7254e 
>   libs/main/KoMainWindow.cpp 3338397 
>   libs/main/KoPrintingDialog.cpp 3ed83bd 
> 
> Diff: http://git.reviewboard.kde.org/r/104913/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jos van den Oever
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120513/11d47d2b/attachment.htm>


More information about the calligra-devel mailing list