Review Request: Fix the autosave recovery system

[Franz Fellner]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104892/#review13681
-----------------------------------------------------------


> * if the user presses yes, they get a new, unnamed document with the autosaved contents. I intentionally do not set the url to the url of the image the autosave file was created from, to avoid accidents. The autosave file is deleted

Ok, there are cases, where not to automatically set the filename would be the better option (calligra crashing, user copies another file over the old, loads it -> recovery + save would destroy the newer file; or working with git and not having the autosave file added to the repository).
But think of people loading their files from "recent documents" or via nepomuk search - it will get quite nasty to figure out, where the currently loaded file came from. If one pressed "yes, recover", then tries to save and the file dialog points to $DOCUMENTS_DIR, then closes the window -> recovery not possible anymore, as the autsave file was deleted.

In order to catch both cases the best solution would be a button "show files side-by-side", and let the user chose which file to load, then it should be save to set the filename.

- Franz Fellner


On May 10, 2012, 1:21 p.m., Boudewijn Rempt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104892/
> -----------------------------------------------------------
> 
> (Updated May 10, 2012, 1:21 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> 1) X-KDE-NativeExtension can be empy, in that case take mime->mainExtension.
>     
>     Otherwise our autosave files are called .autosave, and that's not something
>     the filter's mime detection can handle
>     
> 2) don't overwrite autosave files when running multiple unnamed modified
>     documents
>     
> 3) tag the autosave files with the pid and use dbus to check which processes
>     that have autosave files are still active; don't offer to recover those.
>     
> 4) show the autosave files in a nice dialog with the ora/odf thumbnail
>     as a preview, and offer to recover them all.
> 
> 
> This addresses bug 299611.
>     http://bugs.kde.org/show_bug.cgi?id=299611
> 
> 
> Diffs
> -----
> 
>   krita/image/kis_group_layer.cc ffb542f 
>   libs/main/CMakeLists.txt ea408b7 
>   libs/main/KoApplication.cpp 12ddec3 
>   libs/main/KoAutoSaveRecoveryDialog.h PRE-CREATION 
>   libs/main/KoAutoSaveRecoveryDialog.cpp PRE-CREATION 
>   libs/main/KoDocument.h 0a28c7c 
>   libs/main/KoDocument.cpp d2d3938 
>   libs/main/KoMainWindow.cpp c01f44d 
> 
> Diff: http://git.reviewboard.kde.org/r/104892/diff/
> 
> 
> Testing
> -------
> 
> went manually through all possible scenarios
> 
> 
> Screenshots
> -----------
> 
> autosavefile recovery dialog
>   http://git.reviewboard.kde.org/r/104892/s/561/
> 
> 
> Thanks,
> 
> Boudewijn Rempt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120510/00f223f4/attachment.htm>