Review Request: add i18n strings (changes) blocked by 2.4 release
Thorsten Zachmann
t.zachmann at zagge.de
Wed May 9 04:12:44 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104889/#review13597
-----------------------------------------------------------
Ship it!
Looks good please commit after we clarified how the sentence in marked should be.
plugins/textshape/dialogs/StylesComboPreview.cpp
<http://git.reviewboard.kde.org/r/104889/#comment10789>
I would remove the a in the sentence. For me Create new style ... sounds more natural.
- Thorsten Zachmann
On May 9, 2012, 2:13 a.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104889/
> -----------------------------------------------------------
>
> (Updated May 9, 2012, 2:13 a.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> Saw a few strings that wanted to be updated/translated after the 2.4 release, if not some release before.
>
> For FreehandStrokeStrategy there were only 2 calls without a name parameter, with 1 from a test, so I moved the (translated) default name to the callees.
> In StylesComboPreview the comment looked like it instead should be the real text, so changed that there.
>
>
> Diffs
> -----
>
> plugins/textshape/dialogs/StylesComboPreview.cpp 99ba965
> stage/part/commands/KPrPageEffectSetCommand.cpp 54f56f7
> krita/ui/tool/kis_tool_freehand_helper.cpp 7f289e3
> krita/ui/tool/strokes/freehand_stroke.h 3589386
> krita/ui/tests/freehand_stroke_test.cpp 907cbbd
> filters/karbon/image/ImageExport.cpp 0d32805
> karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsTool.cpp e4d6eea
>
> Diff: http://git.reviewboard.kde.org/r/104889/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120509/bb135794/attachment.htm>
More information about the calligra-devel
mailing list