<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104889/">http://git.reviewboard.kde.org/r/104889/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good please commit after we clarified how the sentence in marked should be.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104889/diff/1/?file=63756#file63756line80" style="color: black; font-weight: bold; text-decoration: underline;">plugins/textshape/dialogs/StylesComboPreview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void StylesComboPreview::init()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">80</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1">//</span><span class="cs">TODO</span><span class="c1"> uncomment the following line after string freeze, also remove the _ in the middle of i18_nc call</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">80</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_addButton</span><span class="o">-></span><span class="n">setToolTip</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"Create a new style with the current properties"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would remove the a in the sentence. For me Create new style ... sounds more natural.</pre>
</div>
<br />
<p>- Thorsten</p>
<br />
<p>On May 9th, 2012, 2:13 a.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated May 9, 2012, 2:13 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Saw a few strings that wanted to be updated/translated after the 2.4 release, if not some release before.
For FreehandStrokeStrategy there were only 2 calls without a name parameter, with 1 from a test, so I moved the (translated) default name to the callees.
In StylesComboPreview the comment looked like it instead should be the real text, so changed that there.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/textshape/dialogs/StylesComboPreview.cpp <span style="color: grey">(99ba965)</span></li>
<li>stage/part/commands/KPrPageEffectSetCommand.cpp <span style="color: grey">(54f56f7)</span></li>
<li>krita/ui/tool/kis_tool_freehand_helper.cpp <span style="color: grey">(7f289e3)</span></li>
<li>krita/ui/tool/strokes/freehand_stroke.h <span style="color: grey">(3589386)</span></li>
<li>krita/ui/tests/freehand_stroke_test.cpp <span style="color: grey">(907cbbd)</span></li>
<li>filters/karbon/image/ImageExport.cpp <span style="color: grey">(0d32805)</span></li>
<li>karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsTool.cpp <span style="color: grey">(e4d6eea)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104889/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>