Review Request: sure new name for style is unique

[mojtaba shahi]

> On May 8, 2012, 9:29 p.m., C. Boemann wrote:
> > plugins/textshape/dialogs/StyleManager.h, line 83
> > <http://git.reviewboard.kde.org/r/104882/diff/2/?file=63677#file63677line83>
> >
> >     Do we really need those bools.
> >     
> >     Could we just change if the name is ok

yes,but think you dont want to change the name and just want to go other style. so if we dont have these bools i should check the list all time when you want to go another style.

i add them to decrease calculations.


> On May 8, 2012, 9:29 p.m., C. Boemann wrote:
> > plugins/textshape/dialogs/StyleManager.cpp, line 122
> > <http://git.reviewboard.kde.org/r/104882/diff/2/?file=63678#file63678line122>
> >
> >     Hmm shouldn't we just set one of those and not both

yes fixed


> On May 8, 2012, 9:29 p.m., C. Boemann wrote:
> > plugins/textshape/dialogs/StyleManager.cpp, line 364
> > <http://git.reviewboard.kde.org/r/104882/diff/2/?file=63678#file63678line364>
> >
> >     remove trailing space

maaaaa  :)


> On May 8, 2012, 9:29 p.m., C. Boemann wrote:
> > plugins/textshape/dialogs/StyleManager.h, line 77
> > <http://git.reviewboard.kde.org/r/104882/diff/2/?file=63677#file63677line77>
> >
> >     We don't need those variables

what do you mean i do every thing and my checking with these two variables. they change when name in general tab change. 


- mojtaba


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104882/#review13588
-----------------------------------------------------------


On May 8, 2012, 6:29 p.m., mojtaba shahi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104882/
> -----------------------------------------------------------
> 
> (Updated May 8, 2012, 6:29 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> when you add new style or when you change name of style, patch checks that the new name for
> 
> style is unique. patch doesnt let you to go another style or close dialog or apply and ok until the name
> 
> that you have choosen for your style be unique.
> 
> 
> Diffs
> -----
> 
>   plugins/textshape/dialogs/CharacterGeneral.h bb72b88 
>   plugins/textshape/dialogs/CharacterGeneral.cpp 4923087 
>   plugins/textshape/dialogs/ParagraphGeneral.h 5ef5c86 
>   plugins/textshape/dialogs/ParagraphGeneral.cpp 8ef5b7f 
>   plugins/textshape/dialogs/StyleManager.h 44dff97 
>   plugins/textshape/dialogs/StyleManager.cpp c318dd7 
>   plugins/textshape/dialogs/StyleManagerDialog.h 56e36b4 
>   plugins/textshape/dialogs/StyleManagerDialog.cpp d423ae0 
>   plugins/textshape/dialogs/StylesModel.h 53c0225 
>   plugins/textshape/dialogs/StylesModel.cpp 3b03f1b 
> 
> Diff: http://git.reviewboard.kde.org/r/104882/diff/
> 
> 
> Testing
> -------
> 
> it is ok and works right :)
> 
> 
> Thanks,
> 
> mojtaba shahi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120508/5caba1ac/attachment.htm>