Review Request: sure new name for style is unique
C. Boemann
cbr at boemann.dk
Tue May 8 22:29:13 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104882/#review13588
-----------------------------------------------------------
plugins/textshape/dialogs/StyleManager.h
<http://git.reviewboard.kde.org/r/104882/#comment10783>
We don't need those variables
plugins/textshape/dialogs/StyleManager.h
<http://git.reviewboard.kde.org/r/104882/#comment10777>
Do we really need those bools.
Could we just change if the name is ok
plugins/textshape/dialogs/StyleManager.cpp
<http://git.reviewboard.kde.org/r/104882/#comment10781>
No need to have these temporary variables
plugins/textshape/dialogs/StyleManager.cpp
<http://git.reviewboard.kde.org/r/104882/#comment10782>
Hmm shouldn't we just set one of those and not both
plugins/textshape/dialogs/StyleManager.cpp
<http://git.reviewboard.kde.org/r/104882/#comment10780>
please leave this blank line
plugins/textshape/dialogs/StyleManager.cpp
<http://git.reviewboard.kde.org/r/104882/#comment10779>
still a trailing space
plugins/textshape/dialogs/StyleManager.cpp
<http://git.reviewboard.kde.org/r/104882/#comment10784>
remove trailing space
- C. Boemann
On May 8, 2012, 6:29 p.m., mojtaba shahi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104882/
> -----------------------------------------------------------
>
> (Updated May 8, 2012, 6:29 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> when you add new style or when you change name of style, patch checks that the new name for
>
> style is unique. patch doesnt let you to go another style or close dialog or apply and ok until the name
>
> that you have choosen for your style be unique.
>
>
> Diffs
> -----
>
> plugins/textshape/dialogs/CharacterGeneral.h bb72b88
> plugins/textshape/dialogs/CharacterGeneral.cpp 4923087
> plugins/textshape/dialogs/ParagraphGeneral.h 5ef5c86
> plugins/textshape/dialogs/ParagraphGeneral.cpp 8ef5b7f
> plugins/textshape/dialogs/StyleManager.h 44dff97
> plugins/textshape/dialogs/StyleManager.cpp c318dd7
> plugins/textshape/dialogs/StyleManagerDialog.h 56e36b4
> plugins/textshape/dialogs/StyleManagerDialog.cpp d423ae0
> plugins/textshape/dialogs/StylesModel.h 53c0225
> plugins/textshape/dialogs/StylesModel.cpp 3b03f1b
>
> Diff: http://git.reviewboard.kde.org/r/104882/diff/
>
>
> Testing
> -------
>
> it is ok and works right :)
>
>
> Thanks,
>
> mojtaba shahi
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120508/9b13f80d/attachment.htm>
More information about the calligra-devel
mailing list