Review Request: KexiDB: fix crashes when saving query design

[Jaroslaw Staniek]

Hi, answering via email below since RB returned server error when tried to
publich my post :)

On 4 May 2012 12:48, Adam Pigg <adam at piggz.co.uk> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104833/
>    kexi/kexidb/relationship.h<http://git.reviewboard.kde.org/r/104833/diff/1/?file=62059#file62059line81> (Diff
> revision 1)
>
> class IndexSchema;
>
>   81
>
>     typedef KexiUtils::AutodeletedList<Relationship*> List;
>
>  81
>
>     typedef QList<Relationship*> List;
>
>   is KexiAutoDeletedList unsafe?  Could it be removed?
>
>
KexiAutoDeletedList was convenient replacement for Qt3 containers with
autodelete option set on. But in this case cross-depemndencies between the
instances lead to double deletion, so normal list is needed. BTW,
autodeleted lists are gone in predicate (and in many cases structures are
implicitly/explicitly shared classes).



>
>    kexi/plugins/queries/kexiquerydesignerguieditor.cpp<http://git.reviewboard.kde.org/r/104833/diff/1/?file=62060#file62060line954> (Diff
> revision 1)
>
> void KexiQueryDesignerGuiEditor::showFieldsOrRelationsForQueryInternal(
>
>   949
>
>     const KexiDB::OrderByColumnList orderByColumns(query->orderByColumnList());
>
>  954
>
>     KexiDB::OrderByColumnList& orderByColumns = query->orderByColumnList();
>
>   is there a problem with the copy constructor?
>
>
>
yes, we did not want to copy here.



-- 
regards / pozdrawiam, Jaroslaw Staniek
 http://www.linkedin.com/in/jstaniek
 Kexi & Calligra (kexi-project.org, identi.ca/kexi, calligra-suite.org)
 KDE Software Development Platform on MS Windows (windows.kde.org)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120506/599ad881/attachment.htm>