Review Request: KexiDB: fix crashes when saving query design

[Adam Pigg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104833/#review13411
-----------------------------------------------------------



kexi/kexidb/relationship.h
<http://git.reviewboard.kde.org/r/104833/#comment10545>

    is KexiAutoDeletedList unsafe?  Could it be removed?



kexi/plugins/queries/kexiquerydesignerguieditor.cpp
<http://git.reviewboard.kde.org/r/104833/#comment10546>

    is there a problem with the copy constructor?


- Adam Pigg


On May 2, 2012, 10:18 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104833/
> -----------------------------------------------------------
> 
> (Updated May 2, 2012, 10:18 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg and Dimitrios Tanis.
> 
> 
> Description
> -------
> 
> KexiDB: fix crashed when saving query design
> 
> *put DESC/ASC after COLLATE section, not before (needed at least for sqlite driver)
> *fixed crash because of invalid deletion order of query structures
> *fixed crash because of invalid deletion relationship structures
> BUG:298197
> 
> 
> Diffs
> -----
> 
>   kexi/doc/dev/CHANGELOG-Kexi-js 3ce83b19d9143f0d23dbe969f1345e296759f351 
>   kexi/kexidb/queryschema.cpp 4b325a7cec89eca5d0a8842f21041a07bd05c98f 
>   kexi/kexidb/relationship.h e6077c81e07d7d6e09311ae299cb6c5e3a918f72 
>   kexi/plugins/queries/kexiquerydesignerguieditor.cpp a38576ca0001a29117c081be7a1c45f23166929d 
> 
> Diff: http://git.reviewboard.kde.org/r/104833/diff/
> 
> 
> Testing
> -------
> 
> Test db works now
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120504/96580ac5/attachment.htm>