Review Request: Make Author information configurable on a settings level

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104843/#review13517
-----------------------------------------------------------

Ship it!


boud was happy enough, and i fixed the few issues he found

- C. Boemann


On May 6, 2012, 12:32 p.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104843/
> -----------------------------------------------------------
> 
> (Updated May 6, 2012, 12:32 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
>    Make author information configurable on a settings level.
>     
>     The Document Information dialog's Author tab becomes read only and just shows who
>     last saved the document.
>     
>     The author information is shared across all calligra apps, and can hold any number of
>     author profiles. The user creates and deletes author profiles through the settings dialog.
>     
>     The profiles are stored in the calligra wide config.
>     
>     In the settings menu a submenu should be added where you can choose the active profile.
>     
>     The active profile is stored in the application's config.
>     
>     BUG:260469
>     BUG:260478
>     It also solves the bug (no number) that save cycles number was never incremented
> 
> 
> Diffs
> -----
> 
>   filters/karbon/xfig/XFigOdgWriter.cpp 299378f 
>   filters/stage/kpr2odf/Filterkpr2odf.cpp b0b4858 
>   flow/part/flow.rc d574de5 
>   karbon/data/karbon.rc 92a8ebd 
>   karbon/ui/dialogs/KarbonConfigureDialog.h 9a591d7 
>   karbon/ui/dialogs/KarbonConfigureDialog.cpp b7a45b1 
>   krita/krita.rc 86b65fe 
>   krita/ui/dialogs/kis_dlg_preferences.cc 8cbcddf 
>   libs/kopageapp/dialogs/KoPAConfigureDialog.h 0cd71f5 
>   libs/kopageapp/dialogs/KoPAConfigureDialog.cpp b7f577c 
>   libs/main/CMakeLists.txt 2eb3681 
>   libs/main/KoDocumentInfo.h 5fe8e21 
>   libs/main/KoDocumentInfo.cpp dff3255 
>   libs/main/KoDocumentInfoDlg.h cf619a2 
>   libs/main/KoDocumentInfoDlg.cpp 4073a8c 
>   libs/main/KoView.h 5f22ba5 
>   libs/main/KoView.cpp 4de2298 
>   libs/main/calligra_shell.rc 6227580 
>   libs/main/config/KoConfigAuthorPage.h PRE-CREATION 
>   libs/main/config/KoConfigAuthorPage.cpp PRE-CREATION 
>   libs/main/config/KoConfigAuthorPage.ui PRE-CREATION 
>   libs/main/koDocumentInfoAuthorWidget.ui c9137b2 
>   sheets/part/dialogs/PreferenceDialog.cpp 2bf53c4 
>   sheets/sheets.rc c002193 
>   stage/stage.rc cc513eb 
>   words/part/KWView.cpp 53f7da5 
>   words/part/words.rc c7a5f90 
> 
> Diff: http://git.reviewboard.kde.org/r/104843/diff/
> 
> 
> Testing
> -------
> 
> tried loading and saving, checking the information inbetween, and also checking the cycle numbers increasing correctly on each save.
> 
> Only thing not working is active profile being updated across views or if the available profiles is changed the menu item to select active profile is not updated to reflect the ist of possible profiles until the app is restarted
> 
> tested that if the active profile has been deleted it will default to save using the default profile
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120506/03937577/attachment.htm>