<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104843/">http://git.reviewboard.kde.org/r/104843/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">boud was happy enough, and i fixed the few issues he found</pre>
<br />
<p>- C.</p>
<br />
<p>On May 6th, 2012, 12:32 p.m., C. Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated May 6, 2012, 12:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> Make author information configurable on a settings level.
The Document Information dialog's Author tab becomes read only and just shows who
last saved the document.
The author information is shared across all calligra apps, and can hold any number of
author profiles. The user creates and deletes author profiles through the settings dialog.
The profiles are stored in the calligra wide config.
In the settings menu a submenu should be added where you can choose the active profile.
The active profile is stored in the application's config.
BUG:260469
BUG:260478
It also solves the bug (no number) that save cycles number was never incremented
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tried loading and saving, checking the information inbetween, and also checking the cycle numbers increasing correctly on each save.
Only thing not working is active profile being updated across views or if the available profiles is changed the menu item to select active profile is not updated to reflect the ist of possible profiles until the app is restarted
tested that if the active profile has been deleted it will default to save using the default profile</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/karbon/xfig/XFigOdgWriter.cpp <span style="color: grey">(299378f)</span></li>
<li>filters/stage/kpr2odf/Filterkpr2odf.cpp <span style="color: grey">(b0b4858)</span></li>
<li>flow/part/flow.rc <span style="color: grey">(d574de5)</span></li>
<li>karbon/data/karbon.rc <span style="color: grey">(92a8ebd)</span></li>
<li>karbon/ui/dialogs/KarbonConfigureDialog.h <span style="color: grey">(9a591d7)</span></li>
<li>karbon/ui/dialogs/KarbonConfigureDialog.cpp <span style="color: grey">(b7a45b1)</span></li>
<li>krita/krita.rc <span style="color: grey">(86b65fe)</span></li>
<li>krita/ui/dialogs/kis_dlg_preferences.cc <span style="color: grey">(8cbcddf)</span></li>
<li>libs/kopageapp/dialogs/KoPAConfigureDialog.h <span style="color: grey">(0cd71f5)</span></li>
<li>libs/kopageapp/dialogs/KoPAConfigureDialog.cpp <span style="color: grey">(b7f577c)</span></li>
<li>libs/main/CMakeLists.txt <span style="color: grey">(2eb3681)</span></li>
<li>libs/main/KoDocumentInfo.h <span style="color: grey">(5fe8e21)</span></li>
<li>libs/main/KoDocumentInfo.cpp <span style="color: grey">(dff3255)</span></li>
<li>libs/main/KoDocumentInfoDlg.h <span style="color: grey">(cf619a2)</span></li>
<li>libs/main/KoDocumentInfoDlg.cpp <span style="color: grey">(4073a8c)</span></li>
<li>libs/main/KoView.h <span style="color: grey">(5f22ba5)</span></li>
<li>libs/main/KoView.cpp <span style="color: grey">(4de2298)</span></li>
<li>libs/main/calligra_shell.rc <span style="color: grey">(6227580)</span></li>
<li>libs/main/config/KoConfigAuthorPage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/config/KoConfigAuthorPage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/config/KoConfigAuthorPage.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/main/koDocumentInfoAuthorWidget.ui <span style="color: grey">(c9137b2)</span></li>
<li>sheets/part/dialogs/PreferenceDialog.cpp <span style="color: grey">(2bf53c4)</span></li>
<li>sheets/sheets.rc <span style="color: grey">(c002193)</span></li>
<li>stage/stage.rc <span style="color: grey">(cc513eb)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(53f7da5)</span></li>
<li>words/part/words.rc <span style="color: grey">(c7a5f90)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104843/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>