Review Request: New shape for 1-D and 2-D barcodes

[Thorsten Zachmann]

> On March 12, 2012, 4:27 a.m., Thorsten Zachmann wrote:
> > Looks very good. I have added some style issues that should be fixed. After that I think it is good for inclusion.
> > 
> > The filename of the classes should use camelcase. So the classes should be renamed to match the case of the class e.g. barcodeshape.cpp -> BarcodeShape.cpp .
> 
> Friedrich W. H. Kossebau wrote:
>     Eh, missed the "After that I think it is good for inclusion." and waited for another review. That is why you did not again comment on this, right?
>     
>     So just to make sure, as I have now fixed the style issues you mentioned, I just go ahead and merge to master, okay?

yes please.


- Thorsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104235/#review11304
-----------------------------------------------------------


On March 12, 2012, 5:42 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104235/
> -----------------------------------------------------------
> 
> (Updated March 12, 2012, 5:42 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Adds a shape for barcodes, based on the lib prison.
> Adding, editing, saving and loading seems to work.
> For non-Calligra consumers of the OpenDocument format a fallback image is stored.
> 
> 
> Diffs
> -----
> 
>   plugins/CMakeLists.txt 69e5d96 
>   plugins/barcodeshape/BarcodeShape.h PRE-CREATION 
>   plugins/barcodeshape/BarcodeShape.cpp PRE-CREATION 
>   plugins/barcodeshape/BarcodeShapeConfigCommand.h PRE-CREATION 
>   plugins/barcodeshape/BarcodeShapeConfigCommand.cpp PRE-CREATION 
>   plugins/barcodeshape/BarcodeShapeConfigWidget.h PRE-CREATION 
>   plugins/barcodeshape/BarcodeShapeConfigWidget.cpp PRE-CREATION 
>   plugins/barcodeshape/BarcodeShapeFactory.h PRE-CREATION 
>   plugins/barcodeshape/BarcodeShapeFactory.cpp PRE-CREATION 
>   plugins/barcodeshape/BarcodeShapePlugin.h PRE-CREATION 
>   plugins/barcodeshape/BarcodeShapePlugin.cpp PRE-CREATION 
>   plugins/barcodeshape/CMakeLists.txt PRE-CREATION 
>   plugins/barcodeshape/Messages.sh PRE-CREATION 
>   plugins/barcodeshape/barcodeshape.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104235/diff/
> 
> 
> Testing
> -------
> 
> Created, edited and deleted barcode shapes. Saved files with barcode shapes and loaded them again.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120328/71e4411c/attachment.htm>