<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104235/">http://git.reviewboard.kde.org/r/104235/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 12th, 2012, 4:27 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks very good. I have added some style issues that should be fixed. After that I think it is good for inclusion.
The filename of the classes should use camelcase. So the classes should be renamed to match the case of the class e.g. barcodeshape.cpp -> BarcodeShape.cpp .</pre>
</blockquote>
<p>On March 28th, 2012, 7:35 a.m., <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Eh, missed the "After that I think it is good for inclusion." and waited for another review. That is why you did not again comment on this, right?
So just to make sure, as I have now fixed the style issues you mentioned, I just go ahead and merge to master, okay?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes please.</pre>
<br />
<p>- Thorsten</p>
<br />
<p>On March 12th, 2012, 5:42 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated March 12, 2012, 5:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds a shape for barcodes, based on the lib prison.
Adding, editing, saving and loading seems to work.
For non-Calligra consumers of the OpenDocument format a fallback image is stored.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Created, edited and deleted barcode shapes. Saved files with barcode shapes and loaded them again.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/CMakeLists.txt <span style="color: grey">(69e5d96)</span></li>
<li>plugins/barcodeshape/BarcodeShape.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/barcodeshape/BarcodeShape.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/barcodeshape/BarcodeShapeConfigCommand.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/barcodeshape/BarcodeShapeConfigCommand.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/barcodeshape/BarcodeShapeConfigWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/barcodeshape/BarcodeShapeConfigWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/barcodeshape/BarcodeShapeFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/barcodeshape/BarcodeShapeFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/barcodeshape/BarcodeShapePlugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/barcodeshape/BarcodeShapePlugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/barcodeshape/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/barcodeshape/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/barcodeshape/barcodeshape.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104235/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>