Review Request: Right-align labels on paragraph/character dialogs

[Friedrich W. H. Kossebau]

> On March 26, 2012, 4:21 a.m., Thorsten Zachmann wrote:
> > In the fonts dialog would it make sense to make the comboboxes the same width in the Highlighting section? I mean the width of the first combobox after the label.

Yes, could be even more eye-friendly, now that I tried it.

And while giving it more love, the whole dialog could also be additionally changed to what there is in master, where meanwhile all groupboxes got removed and the color settings moved below the font family selection.

See the two new screenshots in the zip file I just added.

Want me to backport those changes as well to 2.4, together with the width alignment of all the first parameter combo boxes? I could at least see no related screenshots in the docs which should stop this. Also there is no new setting and no the same variables names in use, AFAIC.


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104408/#review11863
-----------------------------------------------------------


On March 25, 2012, 11:16 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104408/
> -----------------------------------------------------------
> 
> (Updated March 25, 2012, 11:16 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> See summary. Part of some small hopefully agreed on improvements to the formular layouts.
> 
> For pictures see the attached file, e.g. view in gwenview using the arrow keys to see the difference.
> 
> Okay to forward port to master?
> 
> 
> Diffs
> -----
> 
>   plugins/textshape/dialogs/CharacterGeneral.ui b416b5a 
>   plugins/textshape/dialogs/CharacterHighlighting.ui 7e255e9d 
>   plugins/textshape/dialogs/ParagraphBulletsNumbers.ui f059cee 
>   plugins/textshape/dialogs/ParagraphIndentSpacing.ui 80f60a2 
> 
> Diff: http://git.reviewboard.kde.org/r/104408/diff/
> 
> 
> Testing
> -------
> 
> Used all dialogs and did not see any problem.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120326/4f06e608/attachment.htm>