<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104408/">http://git.reviewboard.kde.org/r/104408/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 26th, 2012, 4:21 a.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In the fonts dialog would it make sense to make the comboboxes the same width in the Highlighting section? I mean the width of the first combobox after the label.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, could be even more eye-friendly, now that I tried it.
And while giving it more love, the whole dialog could also be additionally changed to what there is in master, where meanwhile all groupboxes got removed and the color settings moved below the font family selection.
See the two new screenshots in the zip file I just added.
Want me to backport those changes as well to 2.4, together with the width alignment of all the first parameter combo boxes? I could at least see no related screenshots in the docs which should stop this. Also there is no new setting and no the same variables names in use, AFAIC.</pre>
<br />
<p>- Friedrich W. H.</p>
<br />
<p>On March 25th, 2012, 11:16 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated March 25, 2012, 11:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See summary. Part of some small hopefully agreed on improvements to the formular layouts.
For pictures see the attached file, e.g. view in gwenview using the arrow keys to see the difference.
Okay to forward port to master?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Used all dialogs and did not see any problem.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/textshape/dialogs/CharacterGeneral.ui <span style="color: grey">(b416b5a)</span></li>
<li>plugins/textshape/dialogs/CharacterHighlighting.ui <span style="color: grey">(7e255e9d)</span></li>
<li>plugins/textshape/dialogs/ParagraphBulletsNumbers.ui <span style="color: grey">(f059cee)</span></li>
<li>plugins/textshape/dialogs/ParagraphIndentSpacing.ui <span style="color: grey">(80f60a2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104408/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>