Review Request: Fix sqlite3 interface on Windows
Jarosław Staniek
staniek at kde.org
Mon Mar 19 22:56:38 GMT 2012
> On March 18, 2012, 8:19 p.m., Jarosław Staniek wrote:
> > Thank you, very nice, quality fix.
Actually I had to fix two things for gcc/linux. After confirming it works, I will commit for you in master and calligra/2.4.
- Jarosław
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104324/#review11577
-----------------------------------------------------------
On March 18, 2012, 3:44 a.m., Andrius da Costa Ribas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104324/
> -----------------------------------------------------------
>
> (Updated March 18, 2012, 3:44 a.m.)
>
>
> Review request for Calligra, kdewin and Jarosław Staniek.
>
>
> Description
> -------
>
> Fix exporting required symbols of kexidb_sqlite3_icu library for the sqlite3 interface. Also fix the filename extension when loading on different platforms.
>
>
> Diffs
> -----
>
> kexi/kexidb/drivers/sqlite/icu/CMakeLists.txt 8e8be85
> kexi/kexidb/drivers/sqlite/icu/icu.c ae28d70
> kexi/kexidb/drivers/sqlite/icu/sqliteicu.h 69b42f9
> kexi/kexidb/drivers/sqlite/sqliteconnection.cpp f81b539
>
> Diff: http://git.reviewboard.kde.org/r/104324/diff/
>
>
> Testing
> -------
>
> Tested with MSVC 2010 on a Windows 7 machine.
> With that fix, Kexi can create new projects on Windows.
>
>
> Thanks,
>
> Andrius da Costa Ribas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120319/7ac518dc/attachment.htm>
More information about the calligra-devel
mailing list