Review Request: Fix sqlite3 interface on Windows

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104324/#review11639
-----------------------------------------------------------



kexi/kexidb/drivers/sqlite/icu/sqliteicu.h
<http://git.reviewboard.kde.org/r/104324/#comment9226>

    sqlie3ext.h needed instead because we use sqlite3_api_routines structure below



kexi/kexidb/drivers/sqlite/icu/sqliteicu.h
<http://git.reviewboard.kde.org/r/104324/#comment9225>

    should be:
    #if !defined SQLITE_CORE || !SQLITE_CORE


- Jarosław Staniek


On March 18, 2012, 3:44 a.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104324/
> -----------------------------------------------------------
> 
> (Updated March 18, 2012, 3:44 a.m.)
> 
> 
> Review request for Calligra, kdewin and Jarosław Staniek.
> 
> 
> Description
> -------
> 
> Fix exporting required symbols of kexidb_sqlite3_icu library for the sqlite3 interface. Also fix the filename extension when loading on different platforms.
> 
> 
> Diffs
> -----
> 
>   kexi/kexidb/drivers/sqlite/icu/CMakeLists.txt 8e8be85 
>   kexi/kexidb/drivers/sqlite/icu/icu.c ae28d70 
>   kexi/kexidb/drivers/sqlite/icu/sqliteicu.h 69b42f9 
>   kexi/kexidb/drivers/sqlite/sqliteconnection.cpp f81b539 
> 
> Diff: http://git.reviewboard.kde.org/r/104324/diff/
> 
> 
> Testing
> -------
> 
> Tested with MSVC 2010 on a Windows 7 machine.
> With that fix, Kexi can create new projects on Windows.
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120319/4ac32e76/attachment.htm>