Review Request: Recreate the XFig import filter

[Jan Hambrecht]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104312/#review11637
-----------------------------------------------------------

Ship it!


Nice! Please go ahead and commit. It is already a big improvement having a working filter instead of a disabled one.

- Jan Hambrecht


On March 17, 2012, 11:43 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104312/
> -----------------------------------------------------------
> 
> (Updated March 17, 2012, 11:43 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> The XFig import filter got reimplemented to read files in the XFig 3.2 format and turn them into ODG files.
> 
> Large parts of the 3.2 format are supported, so the filter is already quite useful.
> Should be also grateful with bad content and not crash on it.
> 
> Missing for complete 3.2 support, and will be done by the time (if possible at all):
> * multiple pages
> * arc objects
> * spline objects (only imported as pure polylines, no curves, needs someone who know how to turn x-splines to ODG compatible ones)
> * pattern fills
> * different arrow types
> * info about grouping of objects is dropped, due to problem with z-index being intertwined between different groups
> 
> 
> Diffs
> -----
> 
>   filters/karbon/CMakeLists.txt 396040e 
>   filters/karbon/xfig/CMakeLists.txt PRE-CREATION 
>   filters/karbon/xfig/XFigDocument.h PRE-CREATION 
>   filters/karbon/xfig/XFigDocument.cpp PRE-CREATION 
>   filters/karbon/xfig/XFigImportFilter.h PRE-CREATION 
>   filters/karbon/xfig/XFigImportFilter.cpp PRE-CREATION 
>   filters/karbon/xfig/XFigOdgWriter.h PRE-CREATION 
>   filters/karbon/xfig/XFigOdgWriter.cpp PRE-CREATION 
>   filters/karbon/xfig/XFigParser.h PRE-CREATION 
>   filters/karbon/xfig/XFigParser.cpp PRE-CREATION 
>   filters/karbon/xfig/XFigStreamLineReader.h PRE-CREATION 
>   filters/karbon/xfig/XFigStreamLineReader.cpp PRE-CREATION 
>   filters/karbon/xfig/karbon_xfig_import.desktop d47427b 
>   filters/karbon/xfig/xfigimport.h 7803f84 
>   filters/karbon/xfig/xfigimport.cc 889e231 
>   filters/karbon/xfig/xfigimport_factory.h aca3800 
>   filters/karbon/xfig/xfigimport_factory.cc 2a6b691 
> 
> Diff: http://git.reviewboard.kde.org/r/104312/diff/
> 
> 
> Testing
> -------
> 
> Loaded successfully a lot of xfig 3.2 files, including the XFig examples in /usr/share/doc/packages/xfig/TheExamples/
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120319/9543fb11/attachment.htm>