Review Request: User feedback: anti-DOS protection & format checking for file listings

Jarosław Staniek staniek at kde.org
Mon Mar 5 21:28:18 UTC 2012



> On March 5, 2012, 9:20 p.m., Adam Pigg wrote:
> > kexi/main/startup/KexiWelcomeStatusBar.cpp, line 59
> > <http://git.reviewboard.kde.org/r/104158/diff/1/?file=51925#file51925line59>
> >
> >     you mean seconds?

No it's 60 minutes. I did not want to have intrusive machinery here by sending a HTTP request on (virtually) every Kexi startup.


> On March 5, 2012, 9:20 p.m., Adam Pigg wrote:
> > kexi/main/startup/KexiWelcomeStatusBar.cpp, line 149
> > <http://git.reviewboard.kde.org/r/104158/diff/1/?file=51925#file51925line149>
> >
> >     should we message the user?

I don't think because this machinery should be operator-less. In worst case there's fall back to the UIs installed to DATA dir (see main/status/CMakeLists.txt)


> On March 5, 2012, 9:20 p.m., Adam Pigg wrote:
> > kexi/main/startup/KexiWelcomeStatusBar.cpp, line 178
> > <http://git.reviewboard.kde.org/r/104158/diff/1/?file=51925#file51925line178>
> >
> >     should this be \s ?

No, \\ is \ for C++, and then \\s means searching for a whitespace.


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104158/#review11149
-----------------------------------------------------------


On March 4, 2012, 11:16 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104158/
> -----------------------------------------------------------
> 
> (Updated March 4, 2012, 11:16 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg and Dimitrios Tanis.
> 
> 
> Description
> -------
> 
> Main Window
> * User feedback: added anti-DOS protection when updating feedback ui; this means that the client has basic protection even if for some reasons (like server setup bugs) too large files are transmitted as a response
> * User feedback: added checking format of the .list files to avoid erroneous HTTP requests; this means that on any error causing broken content of the .list file (like a 404 or 408 messages), the list will not be considered as valid; this is future-proof protection
> 
> 
> Diffs
> -----
> 
>   kexi/main/startup/KexiWelcomeStatusBar.cpp 6f39e62 
> 
> Diff: http://git.reviewboard.kde.org/r/104158/diff/
> 
> 
> Testing
> -------
> 
> Tested for broken configuration scenario simulated on the kexi-project.org server (lack of file or not sufficient permission).
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120305/43ef26ce/attachment-0001.html>


More information about the calligra-devel mailing list