Review Request: User feedback: anti-DOS protection & format checking for file listings

[Adam Pigg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104158/#review11149
-----------------------------------------------------------



kexi/main/startup/KexiWelcomeStatusBar.cpp
<http://git.reviewboard.kde.org/r/104158/#comment8984>

    you mean seconds?



kexi/main/startup/KexiWelcomeStatusBar.cpp
<http://git.reviewboard.kde.org/r/104158/#comment8989>

    should we message the user?



kexi/main/startup/KexiWelcomeStatusBar.cpp
<http://git.reviewboard.kde.org/r/104158/#comment8987>

    should this be \s ?


- Adam Pigg


On March 4, 2012, 11:16 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104158/
> -----------------------------------------------------------
> 
> (Updated March 4, 2012, 11:16 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg and Dimitrios Tanis.
> 
> 
> Description
> -------
> 
> Main Window
> * User feedback: added anti-DOS protection when updating feedback ui; this means that the client has basic protection even if for some reasons (like server setup bugs) too large files are transmitted as a response
> * User feedback: added checking format of the .list files to avoid erroneous HTTP requests; this means that on any error causing broken content of the .list file (like a 404 or 408 messages), the list will not be considered as valid; this is future-proof protection
> 
> 
> Diffs
> -----
> 
>   kexi/main/startup/KexiWelcomeStatusBar.cpp 6f39e62 
> 
> Diff: http://git.reviewboard.kde.org/r/104158/diff/
> 
> 
> Testing
> -------
> 
> Tested for broken configuration scenario simulated on the kexi-project.org server (lack of file or not sufficient permission).
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120305/b21bfda4/attachment.htm>