Review Request: KoReport: fix save/load page margins

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105305/#review15256
-----------------------------------------------------------


I do appreciate attention to details. After all these iterations I started to think about unit tests: we want to maintain backward compatibility, so tests are really needed in this area - just like for the ODF stuff.

- Jarosław Staniek


On June 29, 2012, 2:13 p.m., Dag Andersen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105305/
> -----------------------------------------------------------
> 
> (Updated June 29, 2012, 2:13 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek and Adam Pigg.
> 
> 
> Description
> -------
> 
> Seems page margins never worked:
> * Saveing used namespace fo, loading used report
> * Loading expected values in pt, saving was in localized value + unit
> 
> This changes:
> * Saving to use namespace 'fo' and value in points.
> * Loading to try to load any value + optional unit (with KoUnit::parseValue()).
> 
> 
> Diffs
> -----
> 
>   libs/koreport/common/KoReportItemBase.cpp 76dc9a8 
>   libs/koreport/common/krreportdata.cpp 4adf547 
>   libs/koreport/common/krutils.h 962e1e7 
>   libs/koreport/common/krutils.cpp 3c2f037 
>   libs/koreport/items/field/KoReportDesignerItemField.cpp 0dc9325 
>   libs/koreport/wrtembed/KoReportDesigner.cpp 78dda97 
>   libs/koreport/wrtembed/KoReportDesignerItemBase.cpp 33bd17d 
>   libs/koreport/wrtembed/KoReportDesignerItemLine.cpp e173787 
>   libs/koreport/wrtembed/reportsection.cpp 2fae3d9 
> 
> Diff: http://git.reviewboard.kde.org/r/105305/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dag Andersen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120629/46162511/attachment.htm>