<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105305/">http://git.reviewboard.kde.org/r/105305/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I do appreciate attention to details. After all these iterations I started to think about unit tests: we want to maintain backward compatibility, so tests are really needed in this area - just like for the ODF stuff.</pre>
<br />
<p>- Jarosław</p>
<br />
<p>On June 29th, 2012, 2:13 p.m., Dag Andersen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Jarosław Staniek and Adam Pigg.</div>
<div>By Dag Andersen.</div>
<p style="color: grey;"><i>Updated June 29, 2012, 2:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems page margins never worked:
* Saveing used namespace fo, loading used report
* Loading expected values in pt, saving was in localized value + unit
This changes:
* Saving to use namespace 'fo' and value in points.
* Loading to try to load any value + optional unit (with KoUnit::parseValue()).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/koreport/common/KoReportItemBase.cpp <span style="color: grey">(76dc9a8)</span></li>
<li>libs/koreport/common/krreportdata.cpp <span style="color: grey">(4adf547)</span></li>
<li>libs/koreport/common/krutils.h <span style="color: grey">(962e1e7)</span></li>
<li>libs/koreport/common/krutils.cpp <span style="color: grey">(3c2f037)</span></li>
<li>libs/koreport/items/field/KoReportDesignerItemField.cpp <span style="color: grey">(0dc9325)</span></li>
<li>libs/koreport/wrtembed/KoReportDesigner.cpp <span style="color: grey">(78dda97)</span></li>
<li>libs/koreport/wrtembed/KoReportDesignerItemBase.cpp <span style="color: grey">(33bd17d)</span></li>
<li>libs/koreport/wrtembed/KoReportDesignerItemLine.cpp <span style="color: grey">(e173787)</span></li>
<li>libs/koreport/wrtembed/reportsection.cpp <span style="color: grey">(2fae3d9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105305/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>