Review Request: make Calligra thumbnailer functional again

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105373/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

Currently the Calligra thumbnailer is slightly broken. It does not really wait for the rendering of the loaded document. And it also claims to support all mimetypes, even if not all of Calligra is built. Attached patch fixes that:

* waits for result of thumbnail rendering
* installs separate thumbnail descriptions per import filter and only if

But this uncovers some problems:
First is that at least for xfig images the imagethumbnailer of kde-runtime hides the Calligra-based one. A quick patch to fix this is up for kde-runtime at https://git.reviewboard.kde.org/r/105371/ . Nothing we can do here.
Second is that the result of KoDocument::generatePreview(QSize) is not really perfect, e.g. it includes the canvas in the result or for Words does not draw anything. But IMHO that should be dealt with in a separate patch.

And some filters could possibly use a preview image from the original format? But that is also outside the scope of this one. 


Diffs
-----

  filters/flow/visio/import/CMakeLists.txt 0f42264 
  filters/flow/visio/import/flow_vsdx_thumbnail.desktop PRE-CREATION 
  filters/karbon/karbon1.x/CMakeLists.txt 127a2aa 
  filters/karbon/karbon1.x/karbon_karbon1x_thumbnail.desktop PRE-CREATION 
  filters/karbon/xfig/CMakeLists.txt b3b21a9 
  filters/karbon/xfig/karbon_xfig_thumbnail.desktop PRE-CREATION 
  filters/sheets/excel/import/CMakeLists.txt 7ae3cbb 
  filters/sheets/excel/import/sheets_excel_thumbnail.desktop PRE-CREATION 
  filters/sheets/xlsx/CMakeLists.txt a637afa 
  filters/sheets/xlsx/sheets_xlsx_thumbnail.desktop PRE-CREATION 
  filters/stage/kpr2odf/CMakeLists.txt 96b5650 
  filters/stage/kpr2odf/stage_kpr_thumbnail.desktop PRE-CREATION 
  filters/stage/powerpoint/CMakeLists.txt 8e5478c 
  filters/stage/powerpoint/stage_powerpoint_thumbnail.desktop PRE-CREATION 
  filters/stage/pptx/CMakeLists.txt 3332270 
  filters/stage/pptx/stage_pptx_thumbnail.desktop PRE-CREATION 
  filters/words/docx/CMakeLists.txt 30111e4 
  filters/words/docx/words_docx_thumbnail.desktop PRE-CREATION 
  filters/words/msword-odf/CMakeLists.txt 2f79f7b 
  filters/words/msword-odf/words_msword_thumbnail.desktop PRE-CREATION 
  filters/words/rtf/import/CMakeLists.txt 4a6fe10 
  filters/words/rtf/import/words_rtf_thumbnail.desktop PRE-CREATION 
  filters/words/wordperfect/import/CMakeLists.txt 5efb0b0 
  filters/words/wordperfect/import/words_wpd_thumbnail.desktop PRE-CREATION 
  filters/words/works/import/CMakeLists.txt 83f5254 
  filters/words/works/import/words_wps_thumbnail.desktop PRE-CREATION 
  krita/plugins/formats/ora/CMakeLists.txt 666de52 
  krita/plugins/formats/ora/krita_ora_thumbnail.desktop PRE-CREATION 
  tools/thumbnail/CMakeLists.txt f7aac3f 
  tools/thumbnail/calligracreator.h dfe50d2 
  tools/thumbnail/calligracreator.cpp eaad66b 
  tools/thumbnail/calligraodgthumbnail.desktop PRE-CREATION 
  tools/thumbnail/calligrathumbnail.desktop 2c2272c 
  tools/thumbnail/kritathumbnail.desktop PRE-CREATION 
  tools/thumbnail/otherofficethumbnail.desktop e62eba1 
  tools/thumbnail/sheetsodsthumbnail.desktop PRE-CREATION 
  tools/thumbnail/stageodpthumbnail.desktop PRE-CREATION 
  tools/thumbnail/wordsodtthumbnail.desktop PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105373/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120628/7f835e88/attachment.htm>