<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105373/">http://git.reviewboard.kde.org/r/105373/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently the Calligra thumbnailer is slightly broken. It does not really wait for the rendering of the loaded document. And it also claims to support all mimetypes, even if not all of Calligra is built. Attached patch fixes that:
* waits for result of thumbnail rendering
* installs separate thumbnail descriptions per import filter and only if
But this uncovers some problems:
First is that at least for xfig images the imagethumbnailer of kde-runtime hides the Calligra-based one. A quick patch to fix this is up for kde-runtime at https://git.reviewboard.kde.org/r/105371/ . Nothing we can do here.
Second is that the result of KoDocument::generatePreview(QSize) is not really perfect, e.g. it includes the canvas in the result or for Words does not draw anything. But IMHO that should be dealt with in a separate patch.
And some filters could possibly use a preview image from the original format? But that is also outside the scope of this one. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/flow/visio/import/CMakeLists.txt <span style="color: grey">(0f42264)</span></li>
<li>filters/flow/visio/import/flow_vsdx_thumbnail.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/karbon/karbon1.x/CMakeLists.txt <span style="color: grey">(127a2aa)</span></li>
<li>filters/karbon/karbon1.x/karbon_karbon1x_thumbnail.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/karbon/xfig/CMakeLists.txt <span style="color: grey">(b3b21a9)</span></li>
<li>filters/karbon/xfig/karbon_xfig_thumbnail.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/sheets/excel/import/CMakeLists.txt <span style="color: grey">(7ae3cbb)</span></li>
<li>filters/sheets/excel/import/sheets_excel_thumbnail.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/sheets/xlsx/CMakeLists.txt <span style="color: grey">(a637afa)</span></li>
<li>filters/sheets/xlsx/sheets_xlsx_thumbnail.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/stage/kpr2odf/CMakeLists.txt <span style="color: grey">(96b5650)</span></li>
<li>filters/stage/kpr2odf/stage_kpr_thumbnail.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/stage/powerpoint/CMakeLists.txt <span style="color: grey">(8e5478c)</span></li>
<li>filters/stage/powerpoint/stage_powerpoint_thumbnail.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/stage/pptx/CMakeLists.txt <span style="color: grey">(3332270)</span></li>
<li>filters/stage/pptx/stage_pptx_thumbnail.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/docx/CMakeLists.txt <span style="color: grey">(30111e4)</span></li>
<li>filters/words/docx/words_docx_thumbnail.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/msword-odf/CMakeLists.txt <span style="color: grey">(2f79f7b)</span></li>
<li>filters/words/msword-odf/words_msword_thumbnail.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/rtf/import/CMakeLists.txt <span style="color: grey">(4a6fe10)</span></li>
<li>filters/words/rtf/import/words_rtf_thumbnail.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/wordperfect/import/CMakeLists.txt <span style="color: grey">(5efb0b0)</span></li>
<li>filters/words/wordperfect/import/words_wpd_thumbnail.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/words/works/import/CMakeLists.txt <span style="color: grey">(83f5254)</span></li>
<li>filters/words/works/import/words_wps_thumbnail.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/plugins/formats/ora/CMakeLists.txt <span style="color: grey">(666de52)</span></li>
<li>krita/plugins/formats/ora/krita_ora_thumbnail.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tools/thumbnail/CMakeLists.txt <span style="color: grey">(f7aac3f)</span></li>
<li>tools/thumbnail/calligracreator.h <span style="color: grey">(dfe50d2)</span></li>
<li>tools/thumbnail/calligracreator.cpp <span style="color: grey">(eaad66b)</span></li>
<li>tools/thumbnail/calligraodgthumbnail.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tools/thumbnail/calligrathumbnail.desktop <span style="color: grey">(2c2272c)</span></li>
<li>tools/thumbnail/kritathumbnail.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tools/thumbnail/otherofficethumbnail.desktop <span style="color: grey">(e62eba1)</span></li>
<li>tools/thumbnail/sheetsodsthumbnail.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tools/thumbnail/stageodpthumbnail.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tools/thumbnail/wordsodtthumbnail.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105373/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>