Review Request: Bibliography database UI

[Smit Patel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105240/
-----------------------------------------------------------

(Updated June 24, 2012, 9:51 p.m.)


Review request for Calligra.


Changes
-------

Fixes following issues
1) In the Bibliography Database dialog, if after pressing Crtl+N and then I cancel the dialog Words crashes.
2) If I open the same table thrice then in the Table selection drop down it is shown thrice
3) On changing the database table either the search box text should be cleared/the results should be filtered for the new table.
4) Keeping the end user in mind the criteria for the filter condition can be a textual description rather that SQL operators (eg. "Not equal to" instead of "<>")
5) A behaviour similar to 3rd point above for filters. Either the filters should be cleared on table change or the filters should be applied to the new table.
6) Data loss - While creating a new database table if the new database name is same as an existing .sqlite file then there should be a confirmation message instead of silently overwriting the original file
7) Do not open or ask for *.sqllite files that do not contain the bibref table

Issues left:
1) A lot of "QSqlDatabasePrivate::addDatabase: duplicate connection name 'qt_sql_default_connection', old connection removed." debug messages in the console please do remove it.
2) Search options are hidden in menu.
3) Option for remove single filter


Description
-------

Bibliography database UI.
1) create/load/save/edit table saved in SQLite file
2) Search in database
3) Apply custom filters to database
4) Integrated this UI with existing insert citation for edit/create cite in database


Diffs (updated)
-----

  plugins/textshape/dialogs/BibliographyDatabaseWindow.h PRE-CREATION 
  plugins/textshape/dialogs/BibliographyDatabaseWindow.cpp PRE-CREATION 
  plugins/textshape/dialogs/BibliographyDb.h PRE-CREATION 
  plugins/textshape/dialogs/BibliographyDb.cpp PRE-CREATION 
  plugins/textshape/dialogs/EditFiltersDialog.h PRE-CREATION 
  plugins/textshape/dialogs/EditFiltersDialog.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105240/diff/


Testing
-------


Thanks,

Smit Patel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120624/9a84031e/attachment.htm>