<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105240/">http://git.reviewboard.kde.org/r/105240/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Smit Patel.</div>
<p style="color: grey;"><i>Updated June 24, 2012, 9:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes following issues
1) In the Bibliography Database dialog, if after pressing Crtl+N and then I cancel the dialog Words crashes.
2) If I open the same table thrice then in the Table selection drop down it is shown thrice
3) On changing the database table either the search box text should be cleared/the results should be filtered for the new table.
4) Keeping the end user in mind the criteria for the filter condition can be a textual description rather that SQL operators (eg. "Not equal to" instead of "<>")
5) A behaviour similar to 3rd point above for filters. Either the filters should be cleared on table change or the filters should be applied to the new table.
6) Data loss - While creating a new database table if the new database name is same as an existing .sqlite file then there should be a confirmation message instead of silently overwriting the original file
7) Do not open or ask for *.sqllite files that do not contain the bibref table
Issues left:
1) A lot of "QSqlDatabasePrivate::addDatabase: duplicate connection name 'qt_sql_default_connection', old connection removed." debug messages in the console please do remove it.
2) Search options are hidden in menu.
3) Option for remove single filter</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bibliography database UI.
1) create/load/save/edit table saved in SQLite file
2) Search in database
3) Apply custom filters to database
4) Integrated this UI with existing insert citation for edit/create cite in database</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/textshape/dialogs/BibliographyDatabaseWindow.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/BibliographyDatabaseWindow.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/BibliographyDb.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/BibliographyDb.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/EditFiltersDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/EditFiltersDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105240/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>